Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tiny_skia #1492

Open
bjorn3 opened this issue May 26, 2024 · 4 comments
Open

Support tiny_skia #1492

bjorn3 opened this issue May 26, 2024 · 4 comments
Labels
A-core-arch Area: Necessary for full core::arch support C-enhancement Category: An issue proposing an enhancement or a PR with one. O-x86_64 Target: x64 processors

Comments

@bjorn3
Copy link
Member

bjorn3 commented May 26, 2024

Necessary for running Zed.

trap at Instance { def: Item(DefId(1:14541 ~ core[60d0]::core_arch::x86::sse2::_mm_cvtps_epi32)), args: [] } (_ZN4core9core_arch3x864sse215_mm_cvtps_epi3217h3438074ff2a744e2E): llvm.x86.sse2.cvtps2dq
@bjorn3 bjorn3 added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-core-arch Area: Necessary for full core::arch support O-x86_64 Target: x64 processors labels May 26, 2024
@zleyyij
Copy link

zleyyij commented Jun 22, 2024

I'd be interested in attempting this issue, although I would probably need some handholding. I do not have any significant experience with assembly, but have contributed to some larger Rust projects before (Axum), and I've been following the compiler for a while.

@bjorn3
Copy link
Member Author

bjorn3 commented Jun 22, 2024

I'm currently trying to completely rework the way vendor intrinsics are implemented. I don't know if it will work out yet, but to avoid your work going to waste if it works out, you may want to hold off working on this until either the rework gets merged (and these intrinsics are like immediately available) or it becomes clear that my idea doesn't work out after all.

@zleyyij
Copy link

zleyyij commented Jun 22, 2024

Sounds good, I appreciate the response :)

Let me know if you need someone to do grunt work, I'm happy to oblige

@bjorn3
Copy link
Member Author

bjorn3 commented Jun 22, 2024

Thanks for the offer. I'm not quite sure what a good first issue for rustc_codegen_cranelift would be though. If you want to help, maybe contribute to Cranelift? A couple of issues that would either directly help cg_clif or make development of cg_clif a bit easier are: bytecodealliance/wasmtime#2827, bytecodealliance/wasmtime#8600 and bytecodealliance/wasmtime#8694. If you want to pick up any of these issues please comment there (or at https://bytecodealliance.zulipchat.com/) to keep this issue a bit tidier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core-arch Area: Necessary for full core::arch support C-enhancement Category: An issue proposing an enhancement or a PR with one. O-x86_64 Target: x64 processors
Projects
None yet
Development

No branches or pull requests

2 participants