Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "object safety" to "dyn compatibility" #18185

Closed
Veykril opened this issue Sep 25, 2024 · 3 comments
Closed

rename "object safety" to "dyn compatibility" #18185

Veykril opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels

Comments

@Veykril
Copy link
Member

Veykril commented Sep 25, 2024

rust-lang/lang-team#286

We have a diagnostic for this now, as well as a hover message that use object safety as the term, we should change that if this goes through.

@lnicola lnicola added the E-easy label Sep 25, 2024
@noahmbright
Copy link
Contributor

Is this as simple as scrubbing the code base for "object_safety", "ObjectSafety", and what not and swapping with dyn_compatibility? I can take care of this if that's the case

@alibektas
Copy link
Member

alibektas commented Sep 28, 2024

Almost. You can check https://github.com/rust-lang/rust-analyzer/tree/master/crates/hir-ty/src/object_safety and see which other parts refer to this part of the codebase change every reference, usage of words "Object Safety" etc.

You can assign yourself by using [at]rustbot claim command as a comment

@noahmbright
Copy link
Contributor

@rustbot claim

Got it. I think between grep, the compiler and a reviewer I can get this taken care of. Hopefully the former 2 make it easy on the latter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants