Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri: update ABI compat checks to accept Option-like types #132057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

miri: update ABI compat checks to accept Option-like types #132057

wants to merge 1 commit into from
+59 −18

Conversation

RalfJung
Copy link
Member

This implements the t-lang decision described here.

Fixes rust-lang/miri#3983

@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2024

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ABI checks do not accept Option-"like" types
3 participants
@RalfJung @rustbot @wesleywiser