Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for std::pipe #3830

Open
RalfJung opened this issue Aug 21, 2024 · 0 comments
Open

Add tests for std::pipe #3830

RalfJung opened this issue Aug 21, 2024 · 0 comments
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@RalfJung
Copy link
Member

std now has a pipe module. We should add a test in Miri to see which OS APIs are required for this.

  • On Unix, AFAIK this uses pipe2. Miri has basic support for that but does not support blocking, so properly supporting std::pipe is blocked on the socketpair part of Implement blocking support for eventfd and socketpair #3665.
  • On Windows, for now it's okay to ignore the test like we do for many other OS APIs. But of course if someone wants to implement this, they can give it a go. :) This will require someone reasonably familiar with Windows APIs since the Miri team does not have the expertise for that.
@RalfJung RalfJung added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement A-shims Area: This affects the external function shims labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Development

No branches or pull requests

1 participant