Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexError in LLM Reranking when handling malformed LLM responses #17353

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

okirmis
Copy link

@okirmis okirmis commented Dec 23, 2024

Description

When parsing LLMRerank responses, lines of the answer containing a valid reference to a document and a comma but no relevance score (like Doc: 5, because it is the most relevant) would throw an IndexError. As the bug is pretty similar, the PR is also quite similar to #16736.

Fixes #17352

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 23, 2024
@okirmis okirmis changed the title Fix IndexError in LLMReranking by catching when handling malformed LLM responses Fix IndexError in LLMReranking when handling malformed LLM responses Dec 23, 2024
@okirmis okirmis changed the title Fix IndexError in LLMReranking when handling malformed LLM responses Fix IndexError in LLM Reranking when handling malformed LLM responses Dec 23, 2024
@logan-markewich logan-markewich self-assigned this Dec 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 23, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) December 23, 2024 16:15
auto-merge was automatically disabled December 23, 2024 16:23

Head branch was pushed to by a user without write access

@logan-markewich logan-markewich enabled auto-merge (squash) December 23, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
2 participants