Add missing awaits in azure chat store #16645
Open
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
nightosong
reviewed
Oct 24, 2024
| @@ -408,13 +416,15 @@ def _get_default_metadata(self, key: str) -> dict: | |||
| "MessageCount": 0, | |||
| } | |||
|
|
|||
| def _get_or_default_metadata(self, metadata_client: TableClient, key: str) -> dict: | |||
| async def _get_or_default_metadata( | |||
| self, metadata_client: TableClient, key: str | |||
There was a problem hiding this comment.
TableClient import in line 7 is unsuitable here.
from azure.data.tables.aio import TableClient is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16642
@mingqxu7 I would appreciate it if you can test this PR -- I don't actually have access to azure to test this! 😅