-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require setting moduleResolution to bundler with this one weird trick #1238
Comments
@himself65 that looks cool - we can also run https://www.npmjs.com/package/@arethetypeswrong/cli in our CI |
That's amazing, let me check |
Good new is that our core module is mostly correct https://arethetypeswrong.github.io/?p=%40llamaindex%2Fcore%400.2.4 |
I think this is because we didn't use bundler in llamaindex module for some reasons. Maybe I should bring it back |
I know the solution in the repo, but I think it's costly now because I don't want put many effort on bundle stuff. each bundler has advantages but also disadvantage, for example tshy will help dual package hazards, but we need exports different module for different js environment, that's why I choose bunchee (comparing with tsup, it's more simple to use). So, Ideally we should write our custom bundle process using rollup, something combiniation similar to jotai and react.
For now I don't have time to make this happen, but I will add to roadmap of stable release. |
tshy does support the adding export conditions for different file paths, but if you want to use something other than tsc for building that is not currently supported. |
Working on this right now |
blocked by huozhi/bunchee#579 Just releazed that there is a bug on bunchee 😢 |
Your note about setting moduleResolution to "bundler" in tsconfig.json made me curious (this shouldn't be necessary in a dual-package setup), so I just checked your types and it looks like there are a good many issues:
https://arethetypeswrong.github.io/?p=llamaindex%400.6.4
I highly recommend looking into building with tshy, it makes dual-package really simple. We recently moved to it in trigger.dev and now our types look like this:
The text was updated successfully, but these errors were encountered: