-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAIAgent chat returns empty sourceNodes and metadata #1015
Comments
yes the
An agent could also have multiple @logan-markewich I think we should deprecate |
@marcusschiesser what would the alternative look like? This is a very well used method for tracking down sources Take a look at python to see how we bubble up source nodes in agents. We have both sources (for tool calls) and source_nodes (in case any tool calls were a query engine with a response object) |
Thanks for the response everyone. We can take advantage of CallbackManager for now. I've also noticed another issue, its not completely related to the source nodes though. |
I see two problems with just having a
With the callbacks, we can solve both problems:
|
Callbacks or instrumentation are ok-ish. As long as you can (as you mentioned) trace back the retrieved nodes to a specific tool/query engine. Hooking into custom callbacks is also slightly less user friendly, at least in python land |
I agree that callbacks are ok-ish.
|
Hello LlamaIndexTS,
I am currently using OpenAIAgent with QueryEngineTool from a custom VectorStoreIndex.
The agent is responding with correct information from the query engine but the sourceNodes and metadata is empty.
Not sure if this is a bug or me misusing the tool.
Thanks in advance,
// response
EngineResponse {
sourceNodes: undefined,
metadata: {},
message: {
content: 'We have two burgers:\n' +
......
The text was updated successfully, but these errors were encountered: