Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution, New. Add Another Item should be activated when storage location chosen, after error. #4438

Closed
2 tasks
cielf opened this issue Jun 9, 2024 · 3 comments · Fixed by #4485
Closed
2 tasks

Comments

@cielf
Copy link
Collaborator

cielf commented Jun 9, 2024

Summary

On Distribution New, if you attempt to save without picking the storage location, and then pick a storage location, the add another item button should be enabled.

Details

Here is a failing sequence, on local, signed in as [email protected]
Steps
Navigate to new distribution form: http://localhost:3000/distributions/new
Leave all fields blank and click Save -> view will render with validation errors (eg: Storage location must exist, etc)
Fill out the form with valid values for Partner and Storage Location
Fill in the first item and quantity
Click "+ Add Another Item"
Expected: Can keep on adding more items
Actual: "+ Add Another Item" button is disabled and can't add any more

this is probably happening on donation and purchase too, but we haven't confirmed that.

Criteria for completion

  • Add another item button gets enabled when storage location is chosen, even after initial errors.
  • Tests to demonstrate this
@Naraveni
Copy link
Contributor

I would like to work on this

@cielf
Copy link
Collaborator Author

cielf commented Jun 13, 2024

Alright. You've got it.

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants