-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unused base item fields #3993
Comments
@cielf so it looks like there are 2 fields that are null for everything ( I can remove those 2 fields for this issue and open another one for the category problem, or try to tackle it in here. Thoughts? |
@dorner I think we clean up those two fields, but put a proto-issue in the backlog for the category problem, under "needs developer discussion". We do need a reliable way to determine whether an item is disposable, etc. Whether that is this (and we add setting the field for superusers) or putting some flags on the items or something else is TBD. I'm not sure I see the problem with using the base item field. Otherwise, what is base item for at all? Which is a fine question in itself. I have added the proto-issue. |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Automatically unassigned after 7 days of inactivity. |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
This is waiting for some testing. |
Automatically unassigned after 7 days of inactivity. |
Summary
Some of the fields on base item are not used. Delete them.
Why
Avoiding future developer confusion
Details
Look at the super user base item form and the BaseItem model. They don't match. Check the fields that are not represented -- if they are not used in the system at all, then they should be deleted.
Criteria for completion
[] migration to delete the fields
[] all tests pass after migration
The text was updated successfully, but these errors were encountered: