Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include diapers in kits in NDBN report values that are based on 'number of diapers'. #3989

Closed
cielf opened this issue Dec 24, 2023 · 10 comments · Fixed by #4017
Closed

Include diapers in kits in NDBN report values that are based on 'number of diapers'. #3989

cielf opened this issue Dec 24, 2023 · 10 comments · Fixed by #4017

Comments

@cielf
Copy link
Collaborator

cielf commented Dec 24, 2023

Summary

The values in the NDBN report that are for number of disposale diapers distributed, and other associated values do not include disposable diapers distributed in kits. They should.

Why

Why not?

Details

Look at the services/reports/acquisition_report_service and services/reports/children_served_report_service
Assume 1 kit per child for the children served part

Criteria for completion

[ ] number of disposable diapers distributed on NDBN report includes disposable diapers in kits
[ ] children served with disposable diapers on NDBN report takes into account disposable diapers in kits
[ ] tests demonstrating the above changes.

@jadekstewart3
Copy link
Contributor

I'd like to take this on :)

@cielf
Copy link
Collaborator Author

cielf commented Dec 30, 2023

Please do.

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Jan 30, 2024
@cielf
Copy link
Collaborator Author

cielf commented Jan 31, 2024

Sill being worked on at this point - we had a delay to settle on terminology

@github-actions github-actions bot removed the stale label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Mar 3, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Mar 3, 2024
@cielf
Copy link
Collaborator Author

cielf commented Mar 3, 2024

@jadekstewart3 -- you were still working on this as of Feb 22 -- checking in -- do you need someone to step in on the gnarly SQL?

@github-actions github-actions bot removed the stale label Mar 4, 2024
@jadekstewart3
Copy link
Contributor

@cielf I think I do, I'm having a heck of a time getting it :/

@cielf
Copy link
Collaborator Author

cielf commented Mar 5, 2024

Honestly, I expected as much -- I'm pretty sure it's really quite hard!

Copy link
Contributor

github-actions bot commented Apr 5, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Apr 5, 2024
@cielf
Copy link
Collaborator Author

cielf commented Apr 5, 2024

Very nearly done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants