-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include diapers in kits in NDBN report values that are based on 'number of diapers'. #3989
Comments
I'd like to take this on :) |
Please do. |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Sill being worked on at this point - we had a delay to settle on terminology |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
@jadekstewart3 -- you were still working on this as of Feb 22 -- checking in -- do you need someone to step in on the gnarly SQL? |
@cielf I think I do, I'm having a heck of a time getting it :/ |
Honestly, I expected as much -- I'm pretty sure it's really quite hard! |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Very nearly done! |
Summary
The values in the NDBN report that are for number of disposale diapers distributed, and other associated values do not include disposable diapers distributed in kits. They should.
Why
Why not?
Details
Look at the services/reports/acquisition_report_service and services/reports/children_served_report_service
Assume 1 kit per child for the children served part
Criteria for completion
[ ] number of disposable diapers distributed on NDBN report includes disposable diapers in kits
[ ] children served with disposable diapers on NDBN report takes into account disposable diapers in kits
[ ] tests demonstrating the above changes.
The text was updated successfully, but these errors were encountered: