Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Attachments not saving in partner profile #3764

Closed
4 tasks
cielf opened this issue Jul 23, 2023 · 11 comments
Closed
4 tasks

[BUG] Attachments not saving in partner profile #3764

cielf opened this issue Jul 23, 2023 · 11 comments

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 23, 2023

Summary

Attachments on partner profiles are not saving. Fix it.

Why

Because sometimes the banks need the documents the partners upload as part of their approval process.

Details

@cielf discovered this while debugging another issue. Initial investigation suggests that there are some reloads that were added in when we added in the counties that are blowing away the actual contents of the attachment so it can't be saved (per @dorner)

Followup that will be needed

Once we have this fixed, we'll need to check if there are any uploads in the period between when it started (April/May .. we'll need to check to find the exact date)

Criteria for completion

  • saving the attachments works
  • tests to demonstrate this
  • the counties validations still work (that's the primal source of the issue -- the reloads are there because of something funky with the validations)
  • PR includes note about followup required.
dorner added a commit that referenced this issue Jul 28, 2023
@dorner dorner self-assigned this Jul 28, 2023
@github-actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Automatically unassigned after 7 days of inactivity.

@dorner dorner self-assigned this Nov 3, 2023
@github-actions github-actions bot removed Help Wanted Groomed + open to all! stale labels Nov 3, 2023
@dorner
Copy link
Collaborator

dorner commented Nov 5, 2023

PR is #3782

Copy link
Contributor

github-actions bot commented Dec 6, 2023

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@patelkrunal31 patelkrunal31 self-assigned this Dec 17, 2023
@patelkrunal31
Copy link
Collaborator

I will take a look at it and see if the existing PR fixes the issue.

@github-actions github-actions bot removed the stale label Dec 18, 2023
@cielf
Copy link
Collaborator Author

cielf commented Jan 8, 2024

Hey @patelkrunal31 What was the result of your investigation?

Copy link
Contributor

github-actions bot commented Feb 8, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

awwaiid added a commit that referenced this issue Mar 3, 2024
@cielf
Copy link
Collaborator Author

cielf commented May 24, 2024

TODO onthis -- write up the very edge case (see the PR) as a more specific issue, and then close this one.

@cielf
Copy link
Collaborator Author

cielf commented Jun 19, 2024

Proto issue added -- at a "this is happening in production" level, because it has in the last month. Closing this issue.

@cielf cielf closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants