Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Profile: Move Program address (if different) to just below the agency information. #3343

Closed
2 tasks
scooter-dangle opened this issue Jan 22, 2023 · 6 comments · Fixed by #4051
Closed
2 tasks
Labels

Comments

@scooter-dangle
Copy link
Collaborator

Summary

Move Program address (if different) fields to just below the agency information in the partner profile.

Why

Consensus From partnerbase working group meeting 20220713 that the fields belong in that order

Details

  • will need to update edit and show for both banks and partners
  • The appearance of these fields is controlled by the banks through "Edit My Information". Whatever choice the bank has made re the "agency stability" section of the profile must be preserved for these fields.
  • the fields involved are program_address1, program_addres2, program_city, program_state, program_zip_code

Suggested approach / advice

Create a new partial for program address (if different), inserting it at the beginning of the optional partials list. Will need a migration to update the organizations' choice of partials appropriately

Criteria for completion

  • Program address (if different) fields moved to just below the agency information in all 4 cases
  • Tests supporting this behaviour
@scooter-dangle scooter-dangle added the Help Wanted Groomed + open to all! label Jan 22, 2023
@confused-cabbage
Copy link
Contributor

confused-cabbage commented Jan 29, 2023

Taking a look at this to see if this is doable for me. Adding photos and my thoughts along the way to perhaps provide more information for someone else if they want to take a shot at it.

  • I first wanted to look at this from the perspective of a partner, so I logged in with the creds for the verified partner [email protected].
    • I am assuming that the show for a partner is where you are logged in as a partner and you click on my organization in the sidebar.

image

- I am assuming that the `edit` for a partner is when you are logged in as a partner and you click on `Edit My Organization` in the left hand sidebar.

image

So I am assuming that I am removing the Program Address (if different) from the Agency Stability partial and creating its own partial that should go directly after the Agency Information. This partial will only render if the fields program_{address1, address2... etc} have values. Relevant file: app/views/partners/profiles/show/_agency_stability.html.erb
On the edit page, I need to create a new partial - despite the Agency Stability and Program Address cards being visually disconnected, they are still in the same partials. Relevant file: app/views/partners/profiles/show/_agency_stability.html.erb

I haven't been able to find the Program Address (if different) or Agency Stability fields on banks. The organization info page http://localhost:3000/diaper_bank/organization doesn't have those fields. Any idea where these might live?

@jadekstewart3
Copy link
Contributor

@confused-cabbage Hi! If you aren't still working on this I would like to take a stab at it!
@scooter-dangle Can you clarify what you mean by: "Move Program address (if different)"? Thank you!

@cielf
Copy link
Collaborator

cielf commented Jan 9, 2024

Hey @jadekstewart3 Just going through old issues and found your question on this one. The label of the group of fields is "Program address (if different)". Does that clear things up? Also -- I think it's been more than long enough for you to take it on if you still want it.

@jadekstewart3
Copy link
Contributor

jadekstewart3 commented Jan 9, 2024

@cielf Sure, I'd be happy to take this on! And yes, that does clear that up for me - thank you!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Jan 10, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants