From 2f75591ec2974d09f758b5ea0fd3cbfb4922e70c Mon Sep 17 00:00:00 2001
From: Brock Wilcox <awwaiid@thelackthereof.org>
Date: Sat, 5 Aug 2023 11:04:13 -0400
Subject: [PATCH] Satiate Rubocop! [#3798]

---
 app/controllers/reports/activity_graph_controller.rb | 1 -
 app/helpers/application_helper.rb                    | 4 ++--
 app/helpers/donations_helper.rb                      | 2 +-
 spec/requests/reports/donations_summary_spec.rb      | 6 +++---
 spec/system/reports/donations_summary_spec.rb        | 6 +++---
 5 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/app/controllers/reports/activity_graph_controller.rb b/app/controllers/reports/activity_graph_controller.rb
index e2ff7a6dcc..356290853e 100644
--- a/app/controllers/reports/activity_graph_controller.rb
+++ b/app/controllers/reports/activity_graph_controller.rb
@@ -25,5 +25,4 @@ def received_distributed_data(range = selected_range)
       "Distributed" => total_distributed_unformatted(range)
     }
   end
-
 end
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index f234be0bc5..e848fb7f85 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -15,11 +15,11 @@ def default_title_content
   end
 
   def active_class(name)
-    name.any? { |path_name| controller_path.include? path_name } ? "active" : controller_path
+    (name.any? { |path_name| controller_path.include? path_name }) ? "active" : controller_path
   end
 
   def menu_open?(name)
-    name.any? { |path_name| controller_path.include? path_name } ? 'menu-open' : ''
+    (name.any? { |path_name| controller_path.include? path_name }) ? 'menu-open' : ''
   end
 
   def can_administrate?
diff --git a/app/helpers/donations_helper.rb b/app/helpers/donations_helper.rb
index 7082e7ccf0..ed07d514ea 100644
--- a/app/helpers/donations_helper.rb
+++ b/app/helpers/donations_helper.rb
@@ -25,4 +25,4 @@ def total_received_donations_unformatted(range = selected_range)
   def total_received_from_product_drives_unformatted(range = selected_range)
     LineItem.active.where(itemizable: current_organization.donations.by_source(:product_drive).during(range)).sum(:quantity)
   end
-end
\ No newline at end of file
+end
diff --git a/spec/requests/reports/donations_summary_spec.rb b/spec/requests/reports/donations_summary_spec.rb
index f6810db25d..bd85a39c52 100644
--- a/spec/requests/reports/donations_summary_spec.rb
+++ b/spec/requests/reports/donations_summary_spec.rb
@@ -1,8 +1,8 @@
-require 'rails_helper'
+require "rails_helper"
 
 RSpec.describe "Reports::DonationsSummary", type: :request do
   let(:default_params) do
-    { organization_id: @organization.to_param }
+    {organization_id: @organization.to_param}
   end
 
   describe "while signed in" do
@@ -15,7 +15,7 @@
         get reports_donations_summary_index_path(default_params.merge(format: response_format))
         response
       end
-      let(:response_format) { 'html' }
+      let(:response_format) { "html" }
 
       it { is_expected.to have_http_status(:success) }
     end
diff --git a/spec/system/reports/donations_summary_spec.rb b/spec/system/reports/donations_summary_spec.rb
index c70f8802ec..55e17ce697 100644
--- a/spec/system/reports/donations_summary_spec.rb
+++ b/spec/system/reports/donations_summary_spec.rb
@@ -20,7 +20,7 @@
 
     context "when visiting the summary page" do
       it "has a link to create a new donation" do
-        visit @url_prefix + "/reports/donations_summary" 
+        visit @url_prefix + "/reports/donations_summary"
         expect(page).to have_link "New Donation", href: "#{@url_prefix}/donations/new"
       end
 
@@ -103,7 +103,7 @@ def create_next_donation(donation_date:)
 
           describe("filtering to '#{filtered_date_range_label}'" + (set_custom_dates ? " (#{custom_dates})" : "")) do
             before do
-              visit @url_prefix + "/reports/donations_summary" 
+              visit @url_prefix + "/reports/donations_summary"
               filter_to_date_range(filtered_date_range_label, custom_dates)
             end
 
@@ -163,4 +163,4 @@ def valid_bracketing_dates(date_range_info)
       [before_filtered_date_range, after_filtered_date_range]
     end
   end
-end
\ No newline at end of file
+end