Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken build from Gradle 7.x.x-- error during compile! - - - I upgraded it too gradle 8.8 , the wrapper and builder completely. #2597

Open
Vampeyer opened this issue Jul 17, 2024 · 2 comments

Comments

@Vampeyer
Copy link

Vampeyer commented Jul 17, 2024

Broken build from Gradle 7.x.x-- error during compile! - - - I upgraded it too gradle 8.8 , the wrapper and builder completely.

And it works , completely ,

Please check my docs and merge as needed , thanks

https://github.com/Vampeyer/rjsk-Arrowhead

@josedahlquist
Copy link
Collaborator

Hello @Vampeyer Thanks for reaching out!

Regarding the mentioned issue. Can you expand in here what's the issue you are facing and under which platforms are you running?

If you have a working solution to improve to the current build, please feel free to create a Pull Request and the Rootstock core squad will gladly review your proposal.

@Vampeyer
Copy link
Author

Vampeyer commented Jul 25, 2024

Hey there @josedahlquist ! , Yes absolutely , just pull from this build and try to build it , and you will see an error message during the compile. This is from gradle 7.x being there , and the gradle wrapper installed.

I had to go through a lengthy process and rebuild a new gradle wrapper , and update it too gradle 8.8 that would compile a .JAR file properly ,
So to do that , I then took the working gradle 8.8 and merged all of the projects files over , until a .jar file could be easily and completely compiled without errors for the node.

to build it and recreate the error , just follow the steps in the read me's , but
I believe you can just pull from here and in the root directory do a gradlew build , and
-- Try and get the output , JAR file thats required to run. It should appear in a folder , but I was experiencing a gradle wrapper class exception of sorts , - I am running windows 10.

  • Just try and build it here as it is and see if it runs , you will likely see an error due too gradles updates, or at least I did.

So I am a noob at doing pull requests but I will do it soo you guys can see the working code and use it how you need. I didn't touch any of the actual node files or anything in it , its just built on a Gradle CLI that I installed on windows 10 ,

  • When installing the gradle on a local build , if you someone were to do the same thing I did , you would have too just follow the Gradle CLI build prompt commands I had also placed in the read me.

--- Sidenote , Gradle is has a few long steps to set up on a windows 10 machine , so I just installed gradle through chocolatey package installer with , choco install gradle , after installing choco through Node.
-- Much easier process !

---So trying to create this build locally , I had to install gradle on my machine , and update the gradle wrapper and merge it over , into gradle 8.8 because the

  • gradlew build was broke.

    whenever recreating my fix I did , One would have to also have gradle installed ,
    and run a Gradle init.
    , in the working repo , you have to press the right prompts ,
    during a gradle init process ,
    for a Java Project and a few others , to be built properly where the .jar file will build.

    I had written down the choices I selected soo you can recreate the gradle wrapper build again if it ever needs updated in the future, but as of now the Gradle build in the repository I have
    was updated too gradle 8.8 and the code
    im trying to share works perfectly well and is structured just a bit different , with a app folder using it as a
    Production build folder , ( thats where the .jar file is generated at now in the build I have , its easy to work with )

And it only makes the app folder and compiles the .jar in there now , because thats how the gradle init
sets up the project.

But yeah ,
Gradle 8.8 is a complete new overhaul with a whole new API thing in it or something , and it was breaking on me , after I tested a few times.

I tested out my gradlew update and it would consistently build a jar file ,

just run both repos too see yourself if you have too because the build was broke when I tired to build
the .jar originally if that helps.

I will try and do a pull request now , thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants