Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all the ways to declare source and patch files #3384

Open
oturpe opened this issue Oct 16, 2024 · 1 comment · May be fixed by #3405
Open

Document all the ways to declare source and patch files #3384

oturpe opened this issue Oct 16, 2024 · 1 comment · May be fixed by #3405

Comments

@oturpe
Copy link
Contributor

oturpe commented Oct 16, 2024

In rpkg#725, there was a need to authoritative documentation of different ways to declare source and patch files in a specfile, but people involved could not find any. The natural place for this would be Spec file format, but it has only very basic description of Source and Patch. I tried looking at other pages as well, but still could not find anything.

Is your feature request related to a problem? Please describe.
rpkg#725

Describe the solution you'd like
In my opinion, a good description of Source and Patch would include, either in those sections or

1.Numbered SourceXX form
2. Unnumbered Source form
3. %sourcelist and %patchlist

Additionally, I could not find the statement that tags are parsed in case-insensitive manner in the spec file format page. It would be good to have that as well.

Describe alternatives you've considered
none

Additional context
none

@dmnks
Copy link
Contributor

dmnks commented Oct 22, 2024

Additionally, I could not find the statement that tags are parsed in case-insensitive manner in the spec file format page. It would be good to have that as well.

I don't think case insensitivity is something we should promote/encourage as that would just make spec files less readable or consistent.

The other points are valid, though. Funnily enough, we never documented the %patchlist and %sourcelist sections, so that's certainly something we should fix.

Thanks for the report!

@dmnks dmnks added this to RPM Oct 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog in RPM Oct 22, 2024
@oturpe oturpe linked a pull request Oct 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants