rpmbuild -bs leaves an unnecessary name-version-build directory behind

[pmatilai]

Reported by @decathorpe in #3381:

Running rpmbuild -bs <spec> leaves behind an empty name-version-build directory. If we need to create the dir, we should at least clean up afterwards (and cleaning up might be easier than trying to avoid creating)

[voxik]

To me, this might be fedpkg thing, but I won't mind if this is going to be fixed on RPM side.

[decathorpe]

fedpkg srpm just does call rpmbuild -bs (with some additional --defines) under the hood, though? So I don't think this can entirely be "fixed" in fedpkg (and adding a workaround there won't fix uses of plain rpmbuild -bs).

[pmatilai]

It's not a fedpkg thing, it's just that in the "traditional" ~/rpmbuild/{SPECS,BUILD,...} layout the directory gets created out of sigh, whereas fedpkg overrides all those to the current directory.

It's a bug in rpmbuild. No need to speculate. There are ... somewhere over a hundred different combinations this stuff be invoked, and this one got overlooked.