Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments deleted from temp folder while compose window remains open #9732

Open
2 tasks done
mary-pe opened this issue Dec 17, 2024 · 1 comment
Open
2 tasks done

Comments

@mary-pe
Copy link

mary-pe commented Dec 17, 2024

Prerequisites

  • I have searched for duplicate or closed issues
  • I can recreate the issue with all plugins disabled

Describe the issue

I would like to report an unusual situation.
We set $config['temp_dir_ttl'] = '4h', but upon checking, it seems that Roundcube enforces a minimum value of 6 hours.
It appears that the attachment deletion process in the temporary folder does not verify whether a compose window is open.
As a result, if an email remains open in the compose window for more than 6 hours, the attachments in the temp directory are deleted, even though they still appear to be present in the compose window.
Consequently, if the email is sent, it will be delivered without the attachments, even though they still appear to be attached.

What browser(s) are you seeing the problem on?

Chrome, Edge

What version of PHP are you using?

8.2

What version of Roundcube are you using?

1.6.8

JavaScript errors

No response

PHP errors

No response

@alecpl
Copy link
Member

alecpl commented Dec 21, 2024

Default is 48 hours for a reason, and minimum is 6 hours.

That being said, in master we already store uploaded files metadata in database. This includes session identifier. So, we could now verify if session exists before we delete the file.

@alecpl alecpl added this to the later milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants