Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CollectionView is inserting "display=list-item" in _insertAndRenderModelView and the grid styling is modified to list. #71

Open
learnyst opened this issue Jan 11, 2016 · 1 comment

Comments

@learnyst
Copy link

In version 0.11.6 the code in _insertAndRenderModelView

            if( thisModelViewWrapped.children().length === 1 )
                thisModelViewWrapped.toggle( ! hideThisModelView );
            else modelView.$el.toggle( ! hideThisModelView );

            thisModelViewWrapped.toggleClass( "not-visible", hideThisModelView );

was replaced by

if( thisModelViewWrapped.children().length === 1 )
                thisModelViewWrapped.toggle( ! hideThisModelView );
            else modelView.$el.toggle( ! hideThisModelView );

            thisModelViewWrapped.toggleClass( "not-visible", hideThisModelView );

jquery toggle adds display:list-item and spoils the grid styling given in css.

@learnyst learnyst changed the title The CollectionView is inserting display:list-item in _insertAndRenderModelView and the grid styling is modified to list. The CollectionView is inserting "display=list-item" in _insertAndRenderModelView and the grid styling is modified to list. Jan 12, 2016
@dgbeck
Copy link
Member

dgbeck commented Jan 14, 2016

@shankar-mahesh thanks for the report! However I am unclear on what the issue is here. I am squinting but the snippets above look identical, and I'n not clear on what the unexpected styling is exactly. Can you provide more information please (e.g. a diff, screenshot, code to reproduce, etc.)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants