-
Notifications
You must be signed in to change notification settings - Fork 60
Message Headers missing dependency information #16
Comments
Has there been any progress on this bug? This is particularly annoying for collecting rosbags from Android devices. |
Rosjava is mostly following a scratch that itch development cycle at the moment. Those of us who are scratching itches right now are working at companies and can commit time to fixes where we need it or can justify it. We don't have a need for this one at our company (yet), so it's on the todo...unless someone else gets a terrific urge to scratch this itch ;) It's probably not too hard to fix - I think you'll need to compare the way gencpp/genpy does things with the code in message_generation. |
To summarise the discussion in the issue posted on common_msgs, a likely source is that the |
Not a proper fix at all, but at least a work-around: as I had quite some bags that contained messages published by rosjava publishers where I ran into the exception reported in ros/common_msgs#20, I went for the nuclear option and wrote something that replaces the msg defs in connection headers in bag files with completely expanded ones. The message definitions obviously need to be available (and identical to what was used by the publisher(s)) on the machine running the script, but that is typically the case. See gavanderhoorn/rosbag_fixer. Edit: just solved a pretty serious oversight in |
Is there any update on this issue? A permanent fix would be greatly appreciated. Currently, I've been having to use the rosbag_fixer quite often (strangely I do not always have the problem) when recording topics with different types of nodes (rosjava and non-rosjava nodes). |
I don't believe there has been any development to fix this. As @stonier writes in his comment above, |
Thanks for the reply. Is there any planned update for rosjava itself? I think the current bug compromises the compatibility with non-rosjava nodes, since recording ros topics into bag files is a very basic ros feature and extensively used for testing purposes. |
I'm just a user, like you :) Dependent on the rosjava gods. |
hi @ramonss, Rosjava is currently developed mainly by its community; there are no developers working full time or part time on it that I know of. If you need this feature, feel free to submit a PR; I'll review it as soon as I can. If it's something that adds new features and doesn't have too much risk of breaking the existing codebase it will be merged rather fast. I've been pretty packed up lately and I don't have the time to implement this right now.
That certainly made me laugh 😅 |
@gavanderhoorn: thanks for the rosbag_fixer script, it works for me on melodic. |
Well, that would be adding a work-around for an issue local to Unless there are other use-cases, I doubt the |
I have created a fix here. I had trouble getting the child headers for dependencies outside of the current package during runtime, so I'm spawning a process for |
It appears that published messages are missing the message definition for the child types which is used for message introspection.
ros/common_msgs#20
The text was updated successfully, but these errors were encountered: