Skip to content
This repository has been archived by the owner on Jan 14, 2023. It is now read-only.

Time class does not follow getter/setter of other messages #2

Open
chadrockey opened this issue Sep 24, 2013 · 1 comment
Open

Time class does not follow getter/setter of other messages #2

chadrockey opened this issue Sep 24, 2013 · 1 comment
Assignees
Labels
Milestone

Comments

@chadrockey
Copy link

@damonkohler @stonier

It looks like here at the Time (and Duration) classes that the method to access secs and nsecs does not follow the same pattern as for the rest of the messages:
https://github.com/rosjava/rosjava_bootstrap/blob/hydro/message_generation/src/main/java/org/ros/message/Time.java#L43

It looks like the old way, not the new "getSecs(), getNSecs(), setSecs(0)" method. So when you access it, the code looks like this:

message.getHeader().getStamp().secs

Do we want to add the methods into the Time and Duration classes?

@ghost ghost assigned damonkohler Sep 24, 2013
@stonier
Copy link
Contributor

stonier commented Sep 26, 2013

Certainly would be more consistent.

@stonier stonier added this to the ToDo milestone Jun 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants