You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
here the event-related function is declared in a isolated event.h header file, but it is not included in the rmw.h.
when we implement a rmw-xxx, we have to include another rmw/event.h, why the event is so special.
The text was updated successfully, but these errors were encountered:
reed-lau
changed the title
why not definite it in the rmw.h
why not definite the event in the rmw.h
Feb 27, 2020
reed-lau
changed the title
why not definite the event in the rmw.h
why not declare the event related function in the rmw.h
Feb 27, 2020
I would rather ask the opposite question: why should everything be declared in a single header? The fact that this single header contains numerous unrelated function declarations and is 1000+ lines long would instead encourage me to split it up into separate files - each containing only functions of a specific category (e.g. pub/sub in one, services in another, etc.).
dirk-thomas
changed the title
why not declare the event related function in the rmw.h
move the functions from rmw.h into multiple separate files
Feb 28, 2020
rmw/rmw/include/rmw/event.h
Line 16 in 28f9185
here the event-related function is declared in a isolated
event.h
header file, but it is not included in the rmw.h.when we implement a rmw-xxx, we have to include another rmw/event.h, why the
event
is so special.The text was updated successfully, but these errors were encountered: