Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the functions from rmw.h into multiple separate files #197

Open
reed-lau opened this issue Feb 27, 2020 · 2 comments
Open

move the functions from rmw.h into multiple separate files #197

reed-lau opened this issue Feb 27, 2020 · 2 comments
Assignees
Labels
backlog enhancement New feature or request

Comments

@reed-lau
Copy link

reed-lau commented Feb 27, 2020

#define RMW__EVENT_H_

here the event-related function is declared in a isolated event.h header file, but it is not included in the rmw.h.
when we implement a rmw-xxx, we have to include another rmw/event.h, why the event is so special.

@reed-lau reed-lau changed the title why not definite it in the rmw.h why not definite the event in the rmw.h Feb 27, 2020
@reed-lau reed-lau changed the title why not definite the event in the rmw.h why not declare the event related function in the rmw.h Feb 27, 2020
@dirk-thomas dirk-thomas added the question Further information is requested label Feb 28, 2020
@dirk-thomas
Copy link
Member

I would rather ask the opposite question: why should everything be declared in a single header? The fact that this single header contains numerous unrelated function declarations and is 1000+ lines long would instead encourage me to split it up into separate files - each containing only functions of a specific category (e.g. pub/sub in one, services in another, etc.).

@reed-lau
Copy link
Author

each containing only functions of a specific category

that sounds great!
I just mean, event is not special enough.

@dirk-thomas dirk-thomas added enhancement New feature or request and removed question Further information is requested labels Feb 28, 2020
@dirk-thomas dirk-thomas changed the title why not declare the event related function in the rmw.h move the functions from rmw.h into multiple separate files Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants