Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum values are never validated #158

Open
cottsay opened this issue Jun 11, 2020 · 0 comments
Open

Enum values are never validated #158

cottsay opened this issue Jun 11, 2020 · 0 comments
Labels
bug

Comments

@cottsay
Copy link
Member

cottsay commented Jun 11, 2020

  • The dynamic_reconfigure.client.Client class currently propagates changes to enum values that are not one of the defined values for the enum.
  • rosrun dynamic_reconfigure dynparam set ... allows a user to set an invalid value.
  • The C++ server also accepts the invalid values, which means that users must manually check the validity of the config.

I'm not sure it would be safe to add these checks post-release, but I thought the issue should be raised.

Inspired by ros-visualization/rqt_reconfigure#80 (comment)
@cottsay cottsay added the bug label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cottsay