Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial code in ros2 branch and host ros2 tutorials in this repository #193

Open
scpeters opened this issue Jun 4, 2021 · 1 comment

Comments

@scpeters
Copy link

scpeters commented Jun 4, 2021

There are ROS 1 tutorials hosted on the ROS wiki at http://wiki.ros.org/image_transport/Tutorials, but I don't see any ros2 tutorials hosted anywhere. Also, the tutorial code exists on the ros2 branch, but it still includes ros.h, so it needs to be ported to ros2 as well.

@jacobperron
Copy link
Contributor

I think it would be better if the tutorial code was actually built as part of this repository. I suggest making it a sibling of the image_transport package so that tools like colcon will pick it up and build it.

mjcarroll pushed a commit that referenced this issue Jul 29, 2021
Fixes #193

This PR ports the existing image_transport tutorials from ROS 1 to ROS 2.

The tutorial code now lives in a dedicated image_transport_tutorial package. The content from http://wiki.ros.org/image_transport/Tutorials is presented in the README and has been updated to work for ROS 2.

Signed-off-by: Rebecca Butler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants