-mtune=generic on RISC‑V is not recognized

[ahmadSum1]

Bug Report

Required Info:

• Operating System:
  • Ubuntu 24.04 (VisionFive 2)
• Computer:
  • VisionFive 2 (RISC-V architecture)
• ROS2 Version:
  • Jazzy, installed from source
• Version or commit hash:
  • 87aae5dc0f078c44ed17f252252b8f629bbcc7e4
• DDS implementation:
  • rmw_zenoh_cpp

---

Steps to reproduce issue

1. Clone the navigation2 repository:

   mkdir -p src
   rosinstall_generator --rosdistro jazzy --deps navigation2 --exclude RPP | vcs import src

2. Navigate to the workspace, source ros2 and attempt to build the nav2_mppi_controller package:

   colcon build --packages-up-to nav2_mppi_controller --cmake-args -DCMAKE_BUILD_TYPE=Release

3. Observe the following errors related to mtune, xtensor and xsimd:

   • --- stderr: nav2_mppi_controller
     cc1plus: error: unknown cpu ‘generic’ for ‘-mtune’
     gmake[2]: *** [gtest/CMakeFiles/gtest_main.dir/build.make:76: gtest/CMakeFiles/gtest_main.dir/src/gtest_main.cc.o] Error 1
     gmake[1]: *** [CMakeFiles/Makefile2:611: gtest/CMakeFiles/gtest_main.dir/all] Error 2
     gmake[1]: *** Waiting for unfinished jobs....
     cc1plus: error: unknown cpu ‘generic’ for ‘-mtune’

   • after setting -mtune=rocket or -mtune=sifive-7-series

         --- stderr: nav2_mppi_controller                                         
     In file included from /usr/include/xtensor/xstorage.hpp:23,
                     from /usr/include/xtensor/xbuffer_adaptor.hpp:21,
                     from /usr/include/xtensor/xtensor.hpp:19,
                     from /home/user/nav2_core_ws/src/navigation2/nav2_mppi_controller/include/nav2_mppi_controller/tools/noise_generator.hpp:28,
                     from /home/user/nav2_core_ws/src/navigation2/nav2_mppi_controller/src/noise_generator.cpp:15:
     /usr/include/xtensor/xtensor_simd.hpp:37:33: error: ‘aligned_mode’ in namespace ‘xsimd’ does not name a type; did you mean ‘aligned_free’?
     37 |     using aligned_mode = xsimd::aligned_mode;
         |                                 ^~~~~~~~~~~~
         |                                 aligned_free
     /usr/include/xtensor/xtensor_simd.hpp:38:35: error: ‘unaligned_mode’ in namespace ‘xsimd’ does not name a type; did you mean ‘aligned_free’?
     38 |     using unaligned_mode = xsimd::unaligned_mode;
         |                                   ^~~~~~~~~~~~~~
         |                                   aligned_free
     /usr/include/xtensor/xtensor_simd.hpp:41:40: error: ‘allocator_alignment’ in namespace ‘xsimd’ does not name a template type
     41 |     using allocator_alignment = xsimd::allocator_alignment<A>;
     . . . .
     
     456 |         constexpr bool simd_strided_assign = traits::simd_strided_assign();
         |                        ^~~~~~~~~~~~~~~~~~~
     gmake[2]: *** [CMakeFiles/mppi_controller.dir/build.make:90: CMakeFiles/mppi_controller.dir/src/optimizer.cpp.o] Error 1
     gmake[1]: *** [CMakeFiles/Makefile2:196: CMakeFiles/mppi_controller.dir/all] Error 2
     gmake: *** [Makefile:146: all] Error 2
     ---
     Failed   <<< nav2_mppi_controller [8min 56s, exited with code 2]

tried with both riscv64-linux-gnu-gcc-11 and riscv64-linux-gnu-gcc-13

---

Expected Behavior

The package should build successfully without requiring manual intervention to disable SIMD optimizations.

---

Actual Behavior

The build fails due to compatibility issues with SIMD and xsimd on the RISC-V platform.

---

fix that worked

To resolve the issue, I applied a workaround:

• Disabled XSIMD in xtensor by adding -DXTENSOR_DISABLE_XSIMD and -DXSIMD_NO_SUPPORTED_ARCH=1 to the CMakeLists.txt.

Patch of my changes is attached:

From 7b39af406bd8a6462e8de95b6c4a92de2f0a1966 Mon Sep 17 00:00:00 2001
From: Sakib Ahmed <[email protected]>
Date: Thu, 23 Jan 2025 19:04:55 +0000
Subject: [PATCH] riscv64-visionfive2 patch

---
 CMakeLists.txt | 64 ++++++++++++++++++++------------------------------
 1 file changed, 25 insertions(+), 39 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 95eabf6c4..cc9ac79ee 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,24 +1,21 @@
 cmake_minimum_required(VERSION 3.5)
 project(nav2_mppi_controller)
 
-add_definitions(-DXTENSOR_ENABLE_XSIMD)
-add_definitions(-DXTENSOR_USE_XSIMD)
+# Definitions to disable SIMD optimizations in xtensor
+add_definitions(-DXTENSOR_DISABLE_XSIMD)
+add_definitions(-DXSIMD_NO_SUPPORTED_ARCH=1)
 
+# Set threading support flags to off
 set(XTENSOR_USE_TBB 0)
 set(XTENSOR_USE_OPENMP 0)
-set(XTENSOR_USE_XSIMD 1)
-
-# set(XTENSOR_DEFAULT_LAYOUT column_major)  # row_major, column_major
-# set(XTENSOR_DEFAULT_TRAVERSAL row_major)  # row_major, column_major
+set(XTENSOR_USE_XSIMD 0)
 
 find_package(ament_cmake REQUIRED)
-find_package(xsimd REQUIRED)
 find_package(xtensor REQUIRED)
 
-include_directories(
-  include
-)
+include_directories(include)
 
+# List of dependencies
 set(dependencies_pkgs
   rclcpp
   nav2_common
@@ -35,38 +32,24 @@ set(dependencies_pkgs
   tf2_ros
 )
 
+# Find each dependency
 foreach(pkg IN LISTS dependencies_pkgs)
   find_package(${pkg} REQUIRED)
 endforeach()
 
+# Declare this package
 nav2_package()
 
-include(CheckCXXCompilerFlag)
-
-check_cxx_compiler_flag("-mno-avx512f" COMPILER_SUPPORTS_AVX512)
-check_cxx_compiler_flag("-msse4.2" COMPILER_SUPPORTS_SSE4)
-check_cxx_compiler_flag("-mavx2" COMPILER_SUPPORTS_AVX2)
-check_cxx_compiler_flag("-mfma" COMPILER_SUPPORTS_FMA)
-
-if(COMPILER_SUPPORTS_AVX512)
-  add_compile_options(-mno-avx512f)
-endif()
-
-if(COMPILER_SUPPORTS_SSE4)
-  add_compile_options(-msse4.2)
-endif()
-
-if(COMPILER_SUPPORTS_AVX2)
-  add_compile_options(-mavx2)
-endif()
-
-if(COMPILER_SUPPORTS_FMA)
-  add_compile_options(-mfma)
-endif()
-
-# If building one the same hardware to be deployed on, try `-march=native`!
-add_compile_options(-O3 -finline-limit=10000000 -ffp-contract=fast -ffast-math -mtune=generic)
+# Compilation flags optimized for RISC-V
+add_compile_options(
+  -O3                   # Optimization level
+  -ffp-contract=fast    # Enable fused multiply-add
+  -ffast-math           # Fast math optimizations
+  -march=rv64gc         # Target RISC-V rv64gc architecture
+  -mtune=sifive-7-series # Tune for SiFive 7-series processors or `rocket`
+)
 
+# Define libraries and their sources
 add_library(mppi_controller SHARED
   src/controller.cpp
   src/optimizer.cpp
@@ -93,13 +76,15 @@ add_library(mppi_critics SHARED
 
 set(libraries mppi_controller mppi_critics)
 
+# Apply compile options and dependencies for each library
 foreach(lib IN LISTS libraries)
   target_compile_options(${lib} PUBLIC -fconcepts)
-  target_include_directories(${lib} PUBLIC ${xsimd_INCLUDE_DIRS})  #  ${OpenMP_INCLUDE_DIRS}
-  target_link_libraries(${lib} xtensor xtensor::optimize xtensor::use_xsimd)
+  target_include_directories(${lib} PUBLIC ${xtensor_INCLUDE_DIRS})
+  target_link_libraries(${lib} xtensor)
   ament_target_dependencies(${lib} ${dependencies_pkgs})
 endforeach()
 
+# Install the libraries and include files
 install(TARGETS mppi_controller mppi_critics
   ARCHIVE DESTINATION lib
   LIBRARY DESTINATION lib
@@ -110,19 +95,20 @@ install(DIRECTORY include/
   DESTINATION include/
 )
 
+# Testing configuration (if enabled)
 if(BUILD_TESTING)
   find_package(ament_lint_auto REQUIRED)
   find_package(ament_cmake_gtest REQUIRED)
-  set(ament_cmake_copyright_FOUND TRUE)
   ament_lint_auto_find_test_dependencies()
   add_subdirectory(test)
-  # add_subdirectory(benchmark)
 endif()
 
+# Export libraries and dependencies
 ament_export_libraries(${libraries})
 ament_export_dependencies(${dependencies_pkgs})
 ament_export_include_directories(include)
 pluginlib_export_plugin_description_file(nav2_core mppic.xml)
 pluginlib_export_plugin_description_file(nav2_mppi_controller critics.xml)
 
+# Finalize the package
 ament_package()
-- 
2.43.0

...

---

Additional Information

• The package is built and executed successfully on the RISC-V platform after applying the workaround.