Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset variable formatting suggestion #20

Open
jmtaylor-fhcrc opened this issue Aug 14, 2019 · 0 comments
Open

Dataset variable formatting suggestion #20

jmtaylor-fhcrc opened this issue Aug 14, 2019 · 0 comments
Assignees
Labels
bug found something that's giving you a headache? use this flag!

Comments

@jmtaylor-fhcrc
Copy link
Contributor

jmtaylor-fhcrc commented Aug 14, 2019

Suggestion

When getting data back from DSR there are mixed casing in the returned dataset.

con <- connectDS()
vtn <- con$getStudy("vtn505")
ics <- vtn$getDataset("ICS")
names(ics)

...returns...

 [1] "ParticipantId"                      "ParticipantVisit/Visit"            
 [3] "visit_day"                          "assay_identifier"                  
 [5] "summary_level"                      "cell_type"                         
 [7] "cell_name"                          "antigen"                           
 [9] "antigen_type"                       "peptide_pool"                      
[11] "protein"                            "protein_panel"                     
[13] "protein_panel_protein"              "protein_panel_protein_peptide_pool"
[15] "specimen_type"                      "functional_marker_name"            
[17] "functional_marker_type"             "clade"                             
[19] "vaccine_matched"                    "response_call"                     
[21] "pctpos"                             "pctpos_adj"                        
[23] "pctpos_neg"                         "lab_code"                          
[25] "exp_assayid"                        "ics_lab_source_key"                
[27] "response_method"                    "control"                           
[29] "pooled_info"                        "study_prot"                        
[31] "functionality_score"                "polyfunctionality_score"

Here, ParticipantId and ParticipantVisit/Visit are formatted differently than the rest of the variables. consider formatting the names of these two fields to match the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug found something that's giving you a headache? use this flag!
Projects
None yet
Development

No branches or pull requests

2 participants