Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestError [HttpError]: Empty value for parameter 'issue_number': undefined #33

Open
aropan opened this issue Dec 3, 2021 · 2 comments · May be fixed by #61
Open

RequestError [HttpError]: Empty value for parameter 'issue_number': undefined #33

aropan opened this issue Dec 3, 2021 · 2 comments · May be fixed by #61

Comments

@aropan
Copy link

aropan commented Dec 3, 2021 •
edited
Loading

I got the error on push:

...
RequestError [HttpError]: Empty value for parameter 'issue_number': undefined
    at /data/actions-runner/_work/_actions/romeovs/lcov-reporter-action/v0.3.1/dist/main.js:22256:15
    at Array.forEach (<anonymous>)
    at /data/actions-runner/_work/_actions/romeovs/lcov-reporter-action/v0.3.1/dist/main.js:22224:12
    at Array.forEach (<anonymous>)
    at validate$1 (/data/actions-runner/_work/_actions/romeovs/lcov-reporter-action/v0.3.1/dist/main.js:22197:23) {
  status: 400,
...

when using config:

...
      - name: Report
        uses: romeovs/[email protected]
        with:
          lcov-file: lcov.info
          lcov-base: base.lcov.info
          github-token: ${{ secrets.GITHUB_TOKEN }}
          filter-changed-files: true
          delete-old-comments: true
...
@aropan
Copy link
Author

aropan commented Dec 3, 2021

I think this problem with check shouldDeleteOldComments. It should be inside condition (github_1.eventName === "pull_request") {:

...
	if (shouldDeleteOldComments) {
		await deleteOldComments(githubClient, options, github_1);
	}

	if (github_1.eventName === "pull_request") {
		await githubClient.issues.createComment({
			repo: github_1.repo.repo,
			owner: github_1.repo.owner,
			issue_number: github_1.payload.pull_request.number,
			body: body,
		});
	} else if (github_1.eventName === "push") {
		await githubClient.repos.createCommitComment({
			repo: github_1.repo.repo,
			owner: github_1.repo.owner,
			commit_sha: options.commit,
			body: body,
		});
	}
...

JoshFeldman95 added a commit to CayabaCare/lcov-reporter-action that referenced this issue Apr 14, 2022
@JoshFeldman95
implemented solution proposed in romeovs#33
c81818c
This was referenced May 4, 2022
Closed
Merged
chrispappas added a commit to Shopify/hoff that referenced this issue May 11, 2022
@chrispappas
Use a forked version that fixes an error in the original action
f89a626 
Original issue reported on Dec 3, 2021, no fix available yet:
romeovs/lcov-reporter-action#33

Fixed in this fork PR: osmind-development-org/lcov-reporter-action#1

And released: https://github.com/osmind-development-org/lcov-reporter-action/releases/tag/v0.3.2
@chrispappas chrispappas mentioned this issue May 11, 2022
Merged
@klausbadelt klausbadelt linked a pull request Mar 5, 2023 that will close this issue
Open
@boly38
Copy link

boly38 commented Jun 13, 2024 •
edited
Loading

@aropan thanks this was saving me too (on a fork :) ), triggering report coverage step for a workflow that is not PR produces this error

in the step we could disable report coverage by adding the if you was talking about 👍

      - name: Report coverage
        if: github.event_name == 'pull_request'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Empty value for parameter 'issue_number': undefined klausbadelt/lcov-reporter-action
2 participants
@aropan @boly38