-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: standard error codes #65
Comments
@tuxcanfly when do we expect this error? |
When blob transactions are failing to be included in blocks due to mempool being full. It would signify two things:
|
is this different from |
Yes, it indicates a generic connection error and maybe retried without modifying the transaction. |
@tuxcanfly I like this. What are your thoughts on introducing some kind of error for this use case (ie: blob not found) celestiaorg/celestia-node#3292 (there's a lot of context in that thread, sorry) |
Implementation ideas
Implementations should return standard error codes so that clients have a way to handle the error and retry if possible.
We can reuse JSONRPC error codes in the range
--32000 to -32099
, clients should map their errors into the standard error codes for e.g.:gRPC can reuse the JSONRPC error codes for simplicity.
Based on the error, the client can retry with a higher fee, different nonce or smaller blob.
Implementations should wrap their error with the corresponding typed error.
E.g.:
The text was updated successfully, but these errors were encountered: