Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Retries, timeouts, error handling logic #111

Open
tzdybal opened this issue Sep 30, 2024 · 0 comments
Open

[Feature Request]: Retries, timeouts, error handling logic #111

tzdybal opened this issue Sep 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tzdybal
Copy link
Member

tzdybal commented Sep 30, 2024

Implementation ideas

Currently go-da provides very basic and minimalistic DA interface, and no logic. Every project trying to use go-da has to implement error handling, retry logic and timeouts. This is a perfect candidate for refactoring.

We already identified set of common errors. For some of them, automatic retry logic can be implemented, other has to be reported to upper layers. We can also create isolated tests simulating many DA error scenarios.

This feature can be implemented in various ways:

  • modify existing proxies (gRPC and JSON-RPC)
  • create go-da wrapper implementation that can handle retries/timeouts over any other go-da implementation

Regardless of the decision, we should try to end up with single implementation, single configuration, and good tests.

@tzdybal tzdybal added the enhancement New feature or request label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant