From 1db47617fa562510198e57ed3d0674134e08edfc Mon Sep 17 00:00:00 2001
From: emildragu <emil.dragu@gmail.com>
Date: Thu, 1 Oct 2015 14:58:55 +0300
Subject: [PATCH] Variable scope bug in template

$sane_* variables get values from a different scope when their
corresponding variable is undef. This happens for wtmp and btmp config
files, causing the config to use values from the first evaluated rule
that is declared somewhere else.
Puppet version - 3.8.2.
---
 manifests/rule.pp | 35 +++++++++++++++++++----------------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/manifests/rule.pp b/manifests/rule.pp
index 22b52019..f72eb45d 100644
--- a/manifests/rule.pp
+++ b/manifests/rule.pp
@@ -178,7 +178,7 @@
   }
 
   case $compress {
-    'undef': {}
+    'undef': { $sane_compress = undef }
     true: { $sane_compress = 'compress' }
     false: { $sane_compress = 'nocompress' }
     default: {
@@ -187,7 +187,7 @@
   }
 
   case $copy {
-    'undef': {}
+    'undef': { $sane_copy = undef }
     true: { $sane_copy = 'copy' }
     false: { $sane_copy = 'nocopy' }
     default: {
@@ -196,7 +196,7 @@
   }
 
   case $copytruncate {
-    'undef': {}
+    'undef': { $sane_copytruncate = undef }
     true: { $sane_copytruncate = 'copytruncate' }
     false: { $sane_copytruncate = 'nocopytruncate' }
     default: {
@@ -205,7 +205,7 @@
   }
 
   case $create {
-    'undef': {}
+    'undef': { $sane_create =  undef }
     true: { $sane_create = 'create' }
     false: { $sane_create = 'nocreate' }
     default: {
@@ -214,7 +214,7 @@
   }
 
   case $delaycompress {
-    'undef': {}
+    'undef': { $sane_delaycompress = undef }
     true: { $sane_delaycompress = 'delaycompress' }
     false: { $sane_delaycompress = 'nodelaycompress' }
     default: {
@@ -223,7 +223,7 @@
   }
 
   case $dateext {
-    'undef': {}
+    'undef': { $sane_dateext = undef }
     true: { $sane_dateext = 'dateext' }
     false: { $sane_dateext = 'nodateext' }
     default: {
@@ -232,7 +232,7 @@
   }
 
   case $mail {
-    'undef': {}
+    'undef': { $sane_mail = undef }
     false: { $sane_mail = 'nomail' }
     default: {
       $sane_mail = "mail ${mail}"
@@ -240,7 +240,7 @@
   }
 
   case $missingok {
-    'undef': {}
+    'undef': { $sane_missingok = undef }
     true: { $sane_missingok = 'missingok' }
     false: { $sane_missingok = 'nomissingok' }
     default: {
@@ -249,7 +249,7 @@
   }
 
   case $olddir {
-    'undef': {}
+    'undef': { $sane_olddir = undef }
     false: { $sane_olddir = 'noolddir' }
     default: {
       $sane_olddir = "olddir ${olddir}"
@@ -257,7 +257,7 @@
   }
 
   case $sharedscripts {
-    'undef': {}
+    'undef': { $sane_sharedscripts = undef }
     true: { $sane_sharedscripts = 'sharedscripts' }
     false: { $sane_sharedscripts = 'nosharedscripts' }
     default: {
@@ -266,7 +266,7 @@
   }
 
   case $shred {
-    'undef': {}
+    'undef': { $sane_shred = undef }
     true: { $sane_shred = 'shred' }
     false: { $sane_shred = 'noshred' }
     default: {
@@ -275,7 +275,7 @@
   }
 
   case $ifempty {
-    'undef': {}
+    'undef': { $sane_ifempty = undef }
     true: { $sane_ifempty = 'ifempty' }
     false: { $sane_ifempty = 'notifempty' }
     default: {
@@ -284,7 +284,7 @@
   }
 
   case $rotate_every {
-    'undef': {}
+    'undef': { $sane_rotate_every = undef }
     'hour', 'hourly': {}
     'day': { $sane_rotate_every = 'daily' }
     'week': { $sane_rotate_every = 'weekly' }
@@ -345,7 +345,8 @@
   }
 
   case $su {
-    'undef',false: {}
+    'undef': { $sane_su = undef }
+    false: {}
     true: { $sane_su = 'su' }
     default: {
       fail("Logrotate::Rule[${name}]: su must be a boolean")
@@ -353,7 +354,8 @@
   }
 
   case $mailfirst {
-    'undef',false: {}
+    'undef': { $sane_mailfirst = undef }
+    false: {}
     true: {
       if $maillast == true {
         fail("Logrotate::Rule[${name}]: Can't set both mailfirst and maillast")
@@ -367,7 +369,8 @@
   }
 
   case $maillast {
-    'undef',false: {}
+    'undef': { $sane_maillast = undef }
+    false: {}
     true: {
       $sane_maillast = 'maillast'
     }