Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided /etc/cron.daily/logrotate is less useful than EL default #34

Open
gregswift opened this issue Apr 21, 2014 · 0 comments
Open

Comments

@gregswift
Copy link

Mainly in that the original provides a log entry when there is something wrong with the logrotate run.. That is something that is very good to have.

notice: /Stage[main]/Logrotate::Base/File[/etc/cron.daily/logrotate]/content: 
--- /etc/cron.daily/logrotate   2013-07-18 10:08:07.000000000 +0000
+++ /tmp/puppet-file20140421-26981-1m3pwq9-0    2014-04-21 14:39:58.000000000 +0000
@@ -1,8 +1,6 @@
 #!/bin/sh
+# THIS FILE IS AUTOMATICALLY DISTRIBUTED BY PUPPET.  ANY CHANGES     WILL BE
+# OVERWRITTEN.

-/usr/sbin/logrotate /etc/logrotate.conf >/dev/null 2>&1
-EXITVALUE=$?
-if [ $EXITVALUE != 0 ]; then
-    /usr/bin/logger -t logrotate "ALERT exited abnormally with [$EXITVALUE]"
-fi
-exit 0
+test -x /usr/sbin/logrotate || exit 0
+/usr/sbin/logrotate /etc/logrotate.conf
geoffdavis pushed a commit to UCSD-ANF/puppet-logrotate that referenced this issue Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant