Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum required defcon version? fontParts? robofab? #22

Open
anthrotype opened this issue Dec 19, 2016 · 1 comment
Open

minimum required defcon version? fontParts? robofab? #22

anthrotype opened this issue Dec 19, 2016 · 1 comment

Comments

@anthrotype
Copy link
Member

anthrotype commented Dec 19, 2016

Extractor does not import defcon directly, so strictly speaking defcon is not an install_requires.

However, you can't do anything with it if you don't provide a defcon Font instance, or something that "quacks" like one ;)

Once we get to write some unit tests, we will at least need to add defcon among the test requirements.

Now, I have a few questions:

  • Does anyone know if the current extractor still works with Robofab RFont instances? If so, is this still a requirement for future versions (I hope not)?
  • Does extractor work with fontParts, and/or is it supposed to? If so, we need to test against that one too.
  • Does the current extractor depends on any specific version/revision/branch/commit/whatever of defcon? I'd assume or ensure it works at least with the only defcon version which we can reliably specify as a pip requirement (ie. version 0.2.0)

/cc @moyogo, @adrientetar, @typesupply, etc. and anybody who has used this more me.

@adrientetar
Copy link
Contributor

Does the current extractor depends on any specific version/revision/branch/commit/whatever of defcon?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants