Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting wireless for nodes/hubs all on local machine #232

Open
stonier opened this issue Dec 10, 2013 · 4 comments
Open

Detecting wireless for nodes/hubs all on local machine #232

stonier opened this issue Dec 10, 2013 · 4 comments
Assignees
Labels
Milestone

Comments

@stonier
Copy link
Member

stonier commented Dec 10, 2013

First thing is this is giving the wrong impression of the system.

Secondly, maybe needs a third state, LOCAL, WIRED, WIRELESS. Dont know if this is possible.

@piyushk
Copy link
Collaborator

piyushk commented Dec 10, 2013

We should be able to check if the hub IP is a local IP address through the network_interface_manager wrapper. I'll test some code and get back to you.

@ghost ghost assigned piyushk Dec 10, 2013
@stonier
Copy link
Member Author

stonier commented Dec 10, 2013

I just had to do something similar for conductor/app manager checks when flagging them to deal with only local clients/controllers.

robotics-in-concert/rocon_concert#147

Rosgraph has some easy network api. I wonder if this can be used here too.

@piyushk
Copy link
Collaborator

piyushk commented Dec 10, 2013

You're right. The rosgraph API is using the same code I was planning on using, and it has probably gone through a fair amount of testing over the years.

One of the mistakes in the code is that network information is being detected independent of the actual hub we connect to. We should probably fix #223 the same time as we fix this error.

@stonier
Copy link
Member Author

stonier commented Dec 10, 2013

ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants