Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only 1 conv layer where supposed to be many #8

Open
KostyaMoonlight opened this issue Jun 10, 2018 · 2 comments
Open

Only 1 conv layer where supposed to be many #8

KostyaMoonlight opened this issue Jun 10, 2018 · 2 comments

Comments

@KostyaMoonlight
Copy link

At model.py at line 241 you have code like:
if use_conv:
conv = ZeroPadding1D(padding=(0, 2048))(x)
for l in range(conv_layers):
x = Conv1D(filters=fc_size, name='conv_{}'.format(l+1), kernel_size=11, padding='valid', activation='relu', strides=2)(conv)

There must be something like:
if use_conv:
conv = ZeroPadding1D(padding=(0, 2048))(x)
x = Conv1D(filters=fc_size, name='conv_{}'.format(1), kernel_size=11, padding='valid', activation='relu', strides=2)(conv)
for l in range(1, conv_layers):
x = Conv1D(filters=fc_size, name='conv_{}'.format(l+1), kernel_size=11, padding='valid', activation='relu', strides=2)(x)

@mrqorib
Copy link

mrqorib commented Aug 5, 2018

@KostyaMoonlight Why do you think that way? I don't see any difference between the code at the top and the bottom, other than the bottom one ensure that there's at least one layer of convolution layer if the user set the conv_layers = 0.

@revive
Copy link

revive commented Sep 3, 2018

@mrqorib Please note the for loop in the top, the x layer is re-defined from the Conv1D operation on the same conv layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants