Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shouldFillInputWithSelection prop #45

Conversation

PatrickDesign
Copy link
Collaborator

@PatrickDesign PatrickDesign commented Oct 3, 2020

Adds ability to sync the input value with the current selected item.

Rebased and blocked the feature behind a prop from #26, thanks @master-elodin!

attribute default description
shouldFillInputWithSelection false Determines whether or not to sync the input value with the current selection.

Closes #25, closes #27

@PatrickDesign PatrickDesign force-pushed the patrickW/feature--add-input-value-sync-prop branch 2 times, most recently from 8c50ce6 to a4ee1d0 Compare October 3, 2020 21:00
@ritz078
Copy link
Owner

ritz078 commented Oct 5, 2020

@master-elodin @PatrickDesign I have left a comment in #25

@PatrickDesign PatrickDesign force-pushed the patrickW/feature--add-input-value-sync-prop branch from a4ee1d0 to b4cad91 Compare October 6, 2020 06:07
@PatrickDesign
Copy link
Collaborator Author

Continued here #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input changing an uncontrolled input of type text to be controlled Click does not set input value
3 participants