Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output valid Quil if DefFrame HARDWARE-OBJECT is a JSON string #1418

Closed
caldwellshane opened this issue Feb 9, 2022 · 1 comment
Closed

Output valid Quil if DefFrame HARDWARE-OBJECT is a JSON string #1418

caldwellshane opened this issue Feb 9, 2022 · 1 comment
Assignees
@caldwellshane

Comments

@caldwellshane
Copy link
Contributor

Per #1417, DefFrame.out currently does not render valid Quil if we put a JSON string into a string field on the DefFrame. I'd like to go ahead and fix that independently of fixing the parser to read back in an escaped string.

The escaped string will have to do in the absence of an allowance in the Quil spec for JSON strings, ee quil-lang/quil#52.
@caldwellshane caldwellshane self-assigned this Feb 9, 2022
@caldwellshane caldwellshane mentioned this issue Feb 9, 2022
Merged
11 tasks
@caldwellshane
Copy link
Contributor Author

This was closed by #1419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caldwellshane caldwellshane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caldwellshane