Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLTE_CHROMOSPHERE prone to crashes #92

Open
jwreep opened this issue Jun 23, 2021 · 1 comment
Open

NLTE_CHROMOSPHERE prone to crashes #92

jwreep opened this issue Jun 23, 2021 · 1 comment

Comments

@jwreep
Copy link
Member

jwreep commented Jun 23, 2021

Running simulations with/without NLTE_CHROMOSPHERE makes a major difference in how often the code crashes or misbehaves. I suspect that the radiative timescale is the general culprit, and needs to be noticeably reduced for numerical stability when this option is switched on. Reducing SAFETY_RADIATION sufficiently will generally get it running, but at the cost of slowing the code considerably.

I don't know if this is a bug per se as numerical stability is always a concern, but it's something we ought to spend some time trying to improve.

(1) Is there a better approximation for the timescale?

(2) Could a new timescale of some sort be introduced that might alleviate the problem?

(3) Other options?

@sjbradshaw
Copy link
Contributor

sjbradshaw commented Jun 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants