Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] - Config options safety check #150

Open
mcanoy opened this issue Mar 8, 2022 · 4 comments
Open

[enhancement] - Config options safety check #150

mcanoy opened this issue Mar 8, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@mcanoy
Copy link

mcanoy commented Mar 8, 2022

📝 Description

Users provide values for Team Name, Cluster Name and Git Server.

A common error users make is to insert https:// in front of the Git Server and Cluster Name. It would be nice if in the js we detected the value and stripped out the invalid part

function setNamesInStorage () {

Bonus 🏆: Strip out all characters than make an invalid url

@oybed

@mcanoy mcanoy added the enhancement New feature or request label Mar 8, 2022
@eformat
Copy link
Member

eformat commented Mar 9, 2022

ha ! its a trick .. to see if you read the very first page of the instructions ...

Screenshot from 2022-03-09 10-12-30

would be nice to validate the input though .. i.e. don't let you enter it in the wrong format, rather than strip it

@oybed
Copy link
Contributor

oybed commented Mar 9, 2022

If this week's pilot is a good indication, we had 100% success rate on this TIP message being missed. Even though it was called out before the technical exercise started + showed on screenshare during a mobbing session - all before ex 1 started.

@springdo
Copy link
Contributor

springdo commented Mar 9, 2022

PR ready for mergé. Would be good to touch base with you guys once you've done your pilot. We're doing two back to back in March / April so feedback and thoughts should be gathered 📦

@mcanoy
Copy link
Author

mcanoy commented Mar 9, 2022

I made this mistake too. Because i grabbed the url from the location bar and then pasted in to the box. So didn't noticed the lead up.

yeah - ideally do a ping to the urls and get a 200 back. but stripping out will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants