-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite in nushell #52
base: master
Are you sure you want to change the base?
Conversation
Issues to note whilst testing:
^CError: nu::shell::column_not_found
× Cannot find column 'Publisher'
╭─[/usr/share/rhino-pkg/modules/pluggables/snap.nu:19:15]
18 │ | detect columns --guess
19 │ | reject Publisher Version
· ───┬── ────┬────
· │ ╰── cannot find column 'Publisher'
· ╰── value originates here
20 │ | rename --column { Name: pkg }
╰────
|
What did you search..? I need reproducible input. |
|
Wait you said this was in a docker container? |
We determined the issue only happens in a docker container. |
TestingInstall nutextNutext is the nu plugin I made that enables us to bring gettext functionality to nu programs. To install it, first clone the repo: git clone https://github.com/Elsie19/nu_plugin_nutext
make build
sudo make install Installing rpk2rpk2 is the actual program. To install it, first clone the repo: git clone -b nushell https://github.com/rhino-linux/rhino-pkg
sudo make install And you should be all good for testing! Notes
Reverting/uninstallingUninstallingNutextTo uninstall nutext, go back into the cloned sudo make uninstall rpk2This is harder because it likely overwrote your bash rpk, and I haven't tested exactly, but reinstalling rpk should do the trick: pacstall -I rhino-pkg-git
sudo rm -rf /usr/share/rhino-pkg/ |
Other stuffWe will have to keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently you need to add the plugin in a nu shell before being able to run it. I will look more into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few issues:
- Unexpected behaviors when not giving a number as an input.
- No
rpk help
command. It seems like you copy/pastedrpk help
output torpk -h
, which presents issues. Furthermore it seems like auto-generated help information displays beneath this - Using
apt-remove
instead ofapt autoremove
- Running
rpk
without arguments returns an error, when it should return the content of the help command.
What i mean by the first point:
- When running
rpk install discord
and I select no options, it will say "selecting discord from snap" and then... fail? - When running
rpk remove discord
and I press enter without putting a number in, it throws an error.
Please ensure that rpk2 has consistent functionality with the first rpk.
That cannot be turned off btw. |
There is no Lines 200 to 203 in 0b7fc65
That's not a command, unless you meant Line 284 in 0b7fc65
In which case those are the same in apt.
Ok. |
Took you 2 months to figure out Line 122 in 90edb60
Don't keep asking me to test the code if you haven't done bare minimum testing yourself. |
modules/pluggables/apt.nu
Outdated
| insert provider 'apt' | ||
} | ||
} else { | ||
[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need a way to add i18n.Done.