Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_requires causes alot of problems #102

Open
nilosweden opened this issue Jun 25, 2019 · 4 comments
Open

setup_requires causes alot of problems #102

nilosweden opened this issue Jun 25, 2019 · 4 comments

Comments

@nilosweden
Copy link

Kindly use the install_requires instead of setup_requires so the dependencies are handled by pip instead of easy install. This causes a lot of problem if you are behind company proxies and creates more maintenance with more configuration files.

is this something you could look into or do I need to fork this?

@lukas-bednar
Copy link
Member

That change breaks pbr mechanism. I don't know, maybe it is time to migrate to something else?
I might try semver, or ???

@lukas-bednar
Copy link
Member

I took a look around for some other semantic versioning tools. For example autosemver also requires usage of setup_requires keyword.
I am not sure how to solve this issue, I know that I don't want to give up on semantic versioning.

I am open to ideas.

@nilosweden
Copy link
Author

Hi Lukas, why dont you just use the semver package and create a simple release script that bumps the version of the project based on that?

for instance: release.py --bump major/minor/patch and a version.py is generated and you import this file in your setup.py and read the version and specify this to the version in setup call?

It does not have to be more complicated than that.
Also the install_requires can be filled with the content of the requirements.txt file. You simply parse the content and supply each row as a line, there are examples on internet.

Let me know if you want me to provide you with more guidance and thanks in advance for considering to move away from pbr.

@lukas-bednar
Copy link
Member

I am sorry for delay, but I was off in past days. Thanks for suggestion ... would you mind to draft some PR? So we can do a review and if it works I am good with getting that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants