Try to see 255 exit code in isolation #873
Closed
+2,329
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| --- | ||
|
|
||
| # By default, everything is an error | ||
| - error: {name: ""} |
There was a problem hiding this comment.
Restyled by prettier-yaml
Suggested change
| - error: {name: ""} | |
| - error: { name: "" } |
Comment on lines
+129
to
+152
| - {name: [Data.Set], as: Set} | ||
| - {name: [Data.Map], as: Map} | ||
| - {name: [Data.HashSet], as: HashSet} | ||
| - {name: [Data.HashMap.Strict], as: HashMap} | ||
| - {name: [Data.Text], as: T} | ||
| - {name: [Data.Text.Encoding], as: T} | ||
| - {name: [Data.Text.IO], as: T} | ||
| - {name: [Data.Text.Lazy], as: TL} | ||
| - {name: [Data.Text.Lazy.Encoding], as: TL} | ||
| - {name: [Data.Text.IO.Lazy], as: TL} | ||
| - {name: [Data.ByteString], as: BS} | ||
| - {name: [Data.ByteString.Lazy], as: BSL} | ||
| - {name: [Data.ByteString.Char8], as: BS8} | ||
| - {name: [Data.ByteString.Lazy.Char8], as: BSL8} | ||
| - {name: [Data.List.NonEmpty], as: NE} | ||
| - {name: [Data.Sequence], as: Seq} | ||
| - {name: Database.Esqueleto.Legacy, within: []} | ||
| - {name: Freckle.CurriculaApi, as: CurriculaApi} | ||
| - name: | ||
| - Freckle.App.OpenTelemetry | ||
| - OpenTelemetry.Context | ||
| - OpenTelemetry.Context.ThreadLocal | ||
| - OpenTelemetry.Trace | ||
| as: Trace |
There was a problem hiding this comment.
Restyled by prettier-yaml
Suggested change
| - {name: [Data.Set], as: Set} | |
| - {name: [Data.Map], as: Map} | |
| - {name: [Data.HashSet], as: HashSet} | |
| - {name: [Data.HashMap.Strict], as: HashMap} | |
| - {name: [Data.Text], as: T} | |
| - {name: [Data.Text.Encoding], as: T} | |
| - {name: [Data.Text.IO], as: T} | |
| - {name: [Data.Text.Lazy], as: TL} | |
| - {name: [Data.Text.Lazy.Encoding], as: TL} | |
| - {name: [Data.Text.IO.Lazy], as: TL} | |
| - {name: [Data.ByteString], as: BS} | |
| - {name: [Data.ByteString.Lazy], as: BSL} | |
| - {name: [Data.ByteString.Char8], as: BS8} | |
| - {name: [Data.ByteString.Lazy.Char8], as: BSL8} | |
| - {name: [Data.List.NonEmpty], as: NE} | |
| - {name: [Data.Sequence], as: Seq} | |
| - {name: Database.Esqueleto.Legacy, within: []} | |
| - {name: Freckle.CurriculaApi, as: CurriculaApi} | |
| - name: | |
| - Freckle.App.OpenTelemetry | |
| - OpenTelemetry.Context | |
| - OpenTelemetry.Context.ThreadLocal | |
| - OpenTelemetry.Trace | |
| as: Trace | |
| - { name: [Data.Set], as: Set } | |
| - { name: [Data.Map], as: Map } | |
| - { name: [Data.HashSet], as: HashSet } | |
| - { name: [Data.HashMap.Strict], as: HashMap } | |
| - { name: [Data.Text], as: T } | |
| - { name: [Data.Text.Encoding], as: T } | |
| - { name: [Data.Text.IO], as: T } | |
| - { name: [Data.Text.Lazy], as: TL } | |
| - { name: [Data.Text.Lazy.Encoding], as: TL } | |
| - { name: [Data.Text.IO.Lazy], as: TL } | |
| - { name: [Data.ByteString], as: BS } | |
| - { name: [Data.ByteString.Lazy], as: BSL } | |
| - { name: [Data.ByteString.Char8], as: BS8 } | |
| - { name: [Data.ByteString.Lazy.Char8], as: BSL8 } | |
| - { name: [Data.List.NonEmpty], as: NE } | |
| - { name: [Data.Sequence], as: Seq } | |
| - { name: Database.Esqueleto.Legacy, within: [] } | |
| - { name: Freckle.CurriculaApi, as: CurriculaApi } | |
| - name: | |
| - Freckle.App.OpenTelemetry | |
| - OpenTelemetry.Context | |
| - OpenTelemetry.Context.ThreadLocal | |
| - OpenTelemetry.Trace | |
| as: Trace |
Comment on lines
+49
to
+54
| - error: {lhs: mapM, rhs: traverse} | ||
| - error: {lhs: mapM_, rhs: traverse_} | ||
| - error: {lhs: forM, rhs: for} | ||
| - error: {lhs: forM_, rhs: for_} | ||
| - error: {lhs: return, rhs: pure} | ||
| - error: {lhs: "only (entityKey x)", rhs: "onlyKey x"} |
There was a problem hiding this comment.
Restyled by prettier-yaml
Suggested change
| - error: {lhs: mapM, rhs: traverse} | |
| - error: {lhs: mapM_, rhs: traverse_} | |
| - error: {lhs: forM, rhs: for} | |
| - error: {lhs: forM_, rhs: for_} | |
| - error: {lhs: return, rhs: pure} | |
| - error: {lhs: "only (entityKey x)", rhs: "onlyKey x"} | |
| - error: { lhs: mapM, rhs: traverse } | |
| - error: { lhs: mapM_, rhs: traverse_ } | |
| - error: { lhs: forM, rhs: for } | |
| - error: { lhs: forM_, rhs: for_ } | |
| - error: { lhs: return, rhs: pure } | |
| - error: { lhs: "only (entityKey x)", rhs: "onlyKey x" } |
| # for ad hoc ways to suppress hlint. | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Restyled by prettier-yaml
Suggested change
Comment on lines
+101
to
+126
| - -XBangPatterns | ||
| - -XDataKinds | ||
| - -XDeriveAnyClass | ||
| - -XDeriveFoldable | ||
| - -XDeriveFunctor | ||
| - -XDeriveGeneric | ||
| - -XDeriveLift | ||
| - -XDeriveTraversable | ||
| - -XDerivingStrategies | ||
| - -XFlexibleContexts | ||
| - -XFlexibleInstances | ||
| - -XGADTs | ||
| - -XGeneralizedNewtypeDeriving | ||
| - -XLambdaCase | ||
| - -XMultiParamTypeClasses | ||
| - -XNoImplicitPrelude | ||
| - -XNoMonomorphismRestriction | ||
| - -XOverloadedRecordDot | ||
| - -XOverloadedStrings | ||
| - -XQuasiQuotes | ||
| - -XRankNTypes | ||
| - -XRecordWildCards | ||
| - -XScopedTypeVariables | ||
| - -XStandaloneDeriving | ||
| - -XTypeApplications | ||
| - -XTypeFamilies |
There was a problem hiding this comment.
Restyled by prettier-yaml
Suggested change
| - -XBangPatterns | |
| - -XDataKinds | |
| - -XDeriveAnyClass | |
| - -XDeriveFoldable | |
| - -XDeriveFunctor | |
| - -XDeriveGeneric | |
| - -XDeriveLift | |
| - -XDeriveTraversable | |
| - -XDerivingStrategies | |
| - -XFlexibleContexts | |
| - -XFlexibleInstances | |
| - -XGADTs | |
| - -XGeneralizedNewtypeDeriving | |
| - -XLambdaCase | |
| - -XMultiParamTypeClasses | |
| - -XNoImplicitPrelude | |
| - -XNoMonomorphismRestriction | |
| - -XOverloadedRecordDot | |
| - -XOverloadedStrings | |
| - -XQuasiQuotes | |
| - -XRankNTypes | |
| - -XRecordWildCards | |
| - -XScopedTypeVariables | |
| - -XStandaloneDeriving | |
| - -XTypeApplications | |
| - -XTypeFamilies | |
| - -XBangPatterns | |
| - -XDataKinds | |
| - -XDeriveAnyClass | |
| - -XDeriveFoldable | |
| - -XDeriveFunctor | |
| - -XDeriveGeneric | |
| - -XDeriveLift | |
| - -XDeriveTraversable | |
| - -XDerivingStrategies | |
| - -XFlexibleContexts | |
| - -XFlexibleInstances | |
| - -XGADTs | |
| - -XGeneralizedNewtypeDeriving | |
| - -XLambdaCase | |
| - -XMultiParamTypeClasses | |
| - -XNoImplicitPrelude | |
| - -XNoMonomorphismRestriction | |
| - -XOverloadedRecordDot | |
| - -XOverloadedStrings | |
| - -XQuasiQuotes | |
| - -XRankNTypes | |
| - -XRecordWildCards | |
| - -XScopedTypeVariables | |
| - -XStandaloneDeriving | |
| - -XTypeApplications | |
| - -XTypeFamilies |
Comment on lines
+93
to
+97
| - ignore: {within: "FreckleCurriculaApi.**.*"} | ||
| - ignore: {within: "RenaissanceGUR.**.*"} | ||
| - ignore: {within: "PerformanceAnalysisService.**.*"} | ||
| - ignore: {within: "BenchmarkService.**.*"} | ||
| - ignore: {within: "RecurlyApi.**.*"} |
There was a problem hiding this comment.
Restyled by prettier-yaml
Suggested change
| - ignore: {within: "FreckleCurriculaApi.**.*"} | |
| - ignore: {within: "RenaissanceGUR.**.*"} | |
| - ignore: {within: "PerformanceAnalysisService.**.*"} | |
| - ignore: {within: "BenchmarkService.**.*"} | |
| - ignore: {within: "RecurlyApi.**.*"} | |
| - ignore: { within: "FreckleCurriculaApi.**.*" } | |
| - ignore: { within: "RenaissanceGUR.**.*" } | |
| - ignore: { within: "PerformanceAnalysisService.**.*" } | |
| - ignore: { within: "BenchmarkService.**.*" } | |
| - ignore: { within: "RecurlyApi.**.*" } |
Comment on lines
+32
to
+46
| - ignore: {name: "Use module export list"} | ||
| - ignore: {name: "Redundant bracket due to operator fixities"} | ||
| - ignore: {name: "Use explicit module export list"} | ||
| - ignore: {name: "Redundant do"} | ||
| - ignore: {name: "Eta reduce"} | ||
| - ignore: {name: "Use list comprehension"} | ||
| - ignore: {name: "Reduce duplication"} | ||
| - ignore: {name: "Use fmap"} # we use classy prelude so this would be in error | ||
| - ignore: {name: "Avoid restricted function", within: Application} | ||
| - ignore: {name: "Use ."} # commonly broken or less readable | ||
| - ignore: {name: "Use &&"} # we like "and" at 3+ elements | ||
| - ignore: {name: "Use ||"} # we like "or" at 3+ elements | ||
| - ignore: {name: "Use join"} # this often leads to cryptic code when do notation is easier to read | ||
| - ignore: {name: "Redundant ^."} # confused by esqueleto's (^.) | ||
| - ignore: {name: "Fuse on/on"} # confused by esqueleto's on |
There was a problem hiding this comment.
Restyled by prettier-yaml
Suggested change
| - ignore: {name: "Use module export list"} | |
| - ignore: {name: "Redundant bracket due to operator fixities"} | |
| - ignore: {name: "Use explicit module export list"} | |
| - ignore: {name: "Redundant do"} | |
| - ignore: {name: "Eta reduce"} | |
| - ignore: {name: "Use list comprehension"} | |
| - ignore: {name: "Reduce duplication"} | |
| - ignore: {name: "Use fmap"} # we use classy prelude so this would be in error | |
| - ignore: {name: "Avoid restricted function", within: Application} | |
| - ignore: {name: "Use ."} # commonly broken or less readable | |
| - ignore: {name: "Use &&"} # we like "and" at 3+ elements | |
| - ignore: {name: "Use ||"} # we like "or" at 3+ elements | |
| - ignore: {name: "Use join"} # this often leads to cryptic code when do notation is easier to read | |
| - ignore: {name: "Redundant ^."} # confused by esqueleto's (^.) | |
| - ignore: {name: "Fuse on/on"} # confused by esqueleto's on | |
| - ignore: { name: "Use module export list" } | |
| - ignore: { name: "Redundant bracket due to operator fixities" } | |
| - ignore: { name: "Use explicit module export list" } | |
| - ignore: { name: "Redundant do" } | |
| - ignore: { name: "Eta reduce" } | |
| - ignore: { name: "Use list comprehension" } | |
| - ignore: { name: "Reduce duplication" } | |
| - ignore: { name: "Use fmap" } # we use classy prelude so this would be in error | |
| - ignore: { name: "Avoid restricted function", within: Application } | |
| - ignore: { name: "Use ." } # commonly broken or less readable | |
| - ignore: { name: "Use &&" } # we like "and" at 3+ elements | |
| - ignore: { name: "Use ||" } # we like "or" at 3+ elements | |
| - ignore: { name: "Use join" } # this often leads to cryptic code when do notation is easier to read | |
| - ignore: { name: "Redundant ^." } # confused by esqueleto's (^.) | |
| - ignore: { name: "Fuse on/on" } # confused by esqueleto's on |
|
OK, this is enough to show, IMO, that when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.