Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and/or handle situation where two recordings have the same recording_id but different application_ids #7950

Open
jleibs opened this issue Oct 30, 2024 · 0 comments
Labels
🪳 bug Something isn't working 🔩 data model 📺 re_viewer affects re_viewer itself

Comments

@jleibs
Copy link
Member

jleibs commented Oct 30, 2024

Explanation

You can easily create some rrds like so:

import rerun as rr

rr.init("rerun_example_app1", recording_id="some_rec_id")
rr.log("hello", rr.TextLog("Hello"))
rr.save("bad1.rrd")

rr.init("rerun_example_app2", recording_id="some_rec_id")
rr.log("hello", rr.TextLog("World"))
rr.save("bad2.rrd")

If you open them in one order: rerun bad1.rrd bad2.rrd you'll see the recording assigned to rerun_example_app1
If you open them in the other order: rerun bad2.rrd bad1.rrd you'll see the recording assigned to rerun_example_app2

This has annoying consequences for things such as blueprint-assignment and general understanding for users.

Proposal

At a minimum, we should detect and warn in this situation.

It would be nice to make the viewer still as usable as possible here. The two possibilities most inline with user intent are:

  • Place the derived joint recording with all of the contents in both apps
  • Keep the individual recordings isolated within their respective apps

Additionally, it would be very nice if we had CLI tool to fix appliation_ids for existing recordings since once you're in this state it's annoying to fix and you don't want to have to re-log your data just to correct it.

@jleibs jleibs added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🔩 data model labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🔩 data model 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

1 participant