Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15 req/s ? #586

Closed
wants to merge 3 commits into from
Closed

15 req/s ? #586

wants to merge 3 commits into from

Conversation

TheHellTower
Copy link

Fixes #524

asportnoy
asportnoy requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@asportnoy asportnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only run 1 request at a time and delay between each one. We want to run as many as possible at a time until we hit 15 within a second, then delay it until it won't be over 15/s.

@TheHellTower
Copy link
Author

Review please 😔

asportnoy
asportnoy requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@asportnoy asportnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still only request one at a time rather than doing them in parallel

@TheHellTower
Copy link
Author

TheHellTower commented Nov 8, 2023 •
edited
Loading

This will still only request one at a time rather than doing them in parallel

Oh so you didn't mean in a row but really all of them at the "exact" same time ?

@asportnoy
Copy link
Member

Yes, it should run as many as possible in parallel until it hits the limit and then throttle starting the next request until 1 second has passed since the first request.

Chri6s added a commit to Chri6s/replugged that referenced this pull request Dec 7, 2023
@Chri6s
Parallel requests
1745ce0 
In theory this should be the fix for the rate limit. ref. replugged-org#586
@Chri6s Chri6s mentioned this pull request Dec 7, 2023
Closed
@FedeIlLeone FedeIlLeone added bug Something isn't working semver: patch Requires a patch semver version bump labels Apr 7, 2024
@TheHellTower TheHellTower closed this by deleting the head repository Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asportnoy asportnoy asportnoy requested changes

Assignees
No one assigned
Labels
bug Something isn't working semver: patch Requires a patch semver version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit number of parallel update requests
3 participants
@TheHellTower @asportnoy @FedeIlLeone