Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-US keyboard doesn't work on Windows Chrome/IE #64

Open
pasieronen opened this issue Aug 7, 2014 · 9 comments
Open

Non-US keyboard doesn't work on Windows Chrome/IE #64

pasieronen opened this issue Aug 7, 2014 · 9 comments

Comments

@pasieronen
Copy link

Characters requiring AltGr (e.g. left square bracket = AltGr+8) on Finnish keyboard don't seem to work at all on IE11 or Chrome 36 running on Windows 7. Chrome 36 on Linux does work, and Firefox works both on Windows and Linux.

@pasieronen
Copy link
Author

FYI, Chrome 36 on Windows 7 triggers these events when typing AltGr-8 (for left square bracket) on a Finnish keyboard:

keydown: keyCode=17 (Ctrl), altKey=false, ctrlKey=true, metaKey=false
keydown: keyCode=18 (Alt), altKey=true, ctrlKey=true, metaKey=false
keydown: keyCode=56 ("8"), altKey=true, ctrlKey=true, metaKey=false
keypress: keyCode=91 ("["), altKey=true, ctrlKey=true, metaKey=false

IE11 on Windows 7 seems to behave identically.

Then jqconsole.coffee's HandleChar ignores the keypress event, because it has ctrlKey=true...

@pasieronen
Copy link
Author

Found this StackOverFlow question with more information:
http://stackoverflow.com/questions/10657346/detect-alt-gr-alt-graph-modifier-on-key-press

Thus, HandleChar's check should probably be "if @State == STATE_OUTPUT or event.metaKey or (event.ctrlKey and !event.altKey)"

@Arminius
Copy link

I can confirm this. I'm using a German keyboard on Chrome 44 and Windows 7. I cannot type '[' (AltGr+8) in the console. It works fine in the editor panel, only the console itself is affected. It also works fine in Firefox.

Please fix this. There are also other projects (I'm thinking specifically of R-Fiddle) using the jqconsole, and they are affected by the same issue.

@ebertmi
Copy link

ebertmi commented Nov 17, 2015

Same bug here on germany keyboard layout. You cannot type in the @ symbol as it requires the Alt Gr key + q.

@AnastasiaDunbar
Copy link

Is this going to be fixed?

@ebertmi
Copy link

ebertmi commented Mar 25, 2017

Well, it has not been fixed in 2 years. Either fork the project and apply the patch yourself or use something like xterm.js

@amasad
Copy link
Contributor

amasad commented Mar 25, 2017

Hey @AnastasiaDunbar it hadn't came up recently so forgot about it. I'll take a look soon

@joaomdsc
Copy link

Hi Amasad,

I'm facing the same issue with a french keyboard, the js console in repl.it is unusable without the ability to type in brackets (and that's a pity :-). I would really appreciate it if you could do something about it. Many thanks in advance,

João

@AnastasiaDunbar
Copy link

I think it's fixed now.

GeraldWodni pushed a commit to GeraldWodni/jq-console-altgr that referenced this issue Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants