Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pr-str through pr-db broken (not readable) #722

Open
FalseProtagonist opened this issue Dec 2, 2024 · 1 comment
Open

[Bug]: pr-str through pr-db broken (not readable) #722

FalseProtagonist opened this issue Dec 2, 2024 · 1 comment
Labels
bug Something isn't working triage

Comments

@FalseProtagonist
Copy link

What version of Datahike are you using?

xx

What version of Java are you using?

xx

What operating system are you using?

xx

What database EDN configuration are you using?

xx

Describe the bug

When you pr-str a DB or something like a TxReport containing a DB, the resulting str is not read-string-able because the pr-db implementation doesn't correctly escape quotes, because internally it uses str not pr-str. being read-string-able is the fundamental contract of pr-str.

Also with love this bug form is completely insane I'm not writing all this when I can see the bug in the source code on the latest branch.

What is the expected behaviour?

xx

How can the behaviour be reproduced?

xx

@FalseProtagonist FalseProtagonist added bug Something isn't working triage labels Dec 2, 2024
@whilo
Copy link
Member

whilo commented Dec 2, 2024

Hey @FalseProtagonist, thanks for opening the issue. I agree that it should be readable with read-string and this should be fixed. It looks like you have already identified a potential fix. Could you open a PR by any chance (ideally for all the issues you opened)? In case where tests will be failing I can help to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants