Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Datom input order is generally not registered within a transaction causing complicated upserts #533

Open
jsmassa opened this issue May 6, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request refactoring

Comments

@jsmassa
Copy link
Collaborator

jsmassa commented May 6, 2022

What version of Datahike are you using?

0.5.1501

What version of Java are you using?

11.0.13 2021-10-19

What operating system are you using?

Ubuntu

What database EDN configuration are you using?

{:index :datahike.index/persistent-set}

Describe the bug

The test in datahike.test.upsert-impl-test/temporal-upsert fails for the persistent set due to the unknown insert order of datoms when they occur in the same transaction.

This is probably the cause for the op-count entry introduced in the hitchhiker-tree operations, but this solution is not optimal since it will cause the problem to occur with each new index data structure. A better solution would be to produce the (temporal) datoms to be added/retracted for the entire transaction entity as a batch and then apply the operations.

What is the expected behaviour?

Same as for the hitchhiker-tree.

How can the behaviour be reproduced?

Replace the index used in this test with the persistent-set index.

@jsmassa jsmassa added bug Something isn't working triage labels May 6, 2022
@jsmassa jsmassa changed the title [Bug]: [Bug]: Datom input order for persistent set is not known within a transaction May 6, 2022
@jsmassa jsmassa added refactoring and removed bug Something isn't working triage labels May 30, 2022
@jsmassa jsmassa changed the title [Bug]: Datom input order for persistent set is not known within a transaction [Bug]: Datom input order is generally not registered within a transaction causing complicated upserts May 30, 2022
@jsmassa jsmassa added the enhancement New feature or request label May 30, 2022
@jsmassa jsmassa self-assigned this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: No status
Development

No branches or pull requests

1 participant