Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define on common identifiers. #146

Open
ladnir opened this issue May 19, 2020 · 4 comments
Open

#define on common identifiers. #146

ladnir opened this issue May 19, 2020 · 4 comments

Comments

@ladnir
Copy link
Contributor

ladnir commented May 19, 2020

The use of very common words for #defines in your headers really does cause problems. Examples are ERROR, thread, TRY, CATCH, and I'm sure there are many more. It would be very appreciated if at some point this was changed to have a RLC_ prefix. At the very least don't use lowercase, i.e. thread.

Thanks,
Peter

@dfaranha
Copy link
Contributor

Point taken! There was some progress on this, as development started to keep up again.
I was planning to fix the most glaring ones and revamp the configuration next weekend due to a holiday.

@ladnir
Copy link
Contributor Author

ladnir commented May 20, 2020

Its appriciated and thanks for relic!

@dfaranha
Copy link
Contributor

I think I have prefixed all externally visible symbols now (except config), and I will probably leave BENCH and TEST without prefix because they are not included in relic.h

I still have to sort out the configuration though, in a way to avoid RLC everywhere.

@ladnir
Copy link
Contributor Author

ladnir commented Jun 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants