Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] add mongo tests #14

Closed
15 tasks
yk-eukarya opened this issue Jul 26, 2021 · 2 comments
Closed
15 tasks

[BE] add mongo tests #14

yk-eukarya opened this issue Jul 26, 2021 · 2 comments
Assignees

Comments

@yk-eukarya
Copy link
Contributor

yk-eukarya commented Jul 26, 2021

Implement unit tests in internal/infrastructure/mongo

Refer to reearth/reearth-backend#139 to learn about how to write tests for mongo.

@HideBa HideBa changed the title Infrastructure test(specifically mongo) [BE]Infrastructure test(specifically mongo) Feb 1, 2022
@rot1024
Copy link
Member

rot1024 commented Mar 7, 2022

MongoDB is so versatile that it is very difficult to mock, and even if mocked, it is not very useful.

Therefore, I think it is appropriate to implement internal/infrastructure/mongo/*_test.go as a unit test that works only when the MongoDB URL is specified in an environment variable. However, we need to consider whether it is a good idea to change the execution of the unit test depending on the environment variable.

@rot1024 rot1024 changed the title [BE]Infrastructure test(specifically mongo) [BE] add mongo test May 10, 2022
@rot1024 rot1024 changed the title [BE] add mongo test [BE] add mongo tests May 10, 2022
@HideBa HideBa assigned yuuri111 and unassigned mimoham24 and yk-eukarya Jun 17, 2022
@yuuri111
Copy link
Contributor

I started writing unittest of [auth_request.go].

KeisukeYamashita pushed a commit that referenced this issue Aug 13, 2022
pyshx pushed a commit that referenced this issue Apr 17, 2023
* Import google sheet icon

* Add import from google drive option

* Add import from google drive second view

* import google script

* Add sheet file icon

* Add additional/optional parameters to assets card

* Add importing google sheet graphQL changes

* Add google sheet import

* Fix params

* save chages

* save changes

* Fix scopes

* fix picker function

* Fix permissions

* re-sync dataset data

* close modal after import

* Change default icon color

* Fix typo

* abstract styles

* Fix message

* No need for initial values

* Fix conflict

* No need for isImage

* Add types

* re-export type

* Remove isImage property

Co-authored-by: basel.issmail <[email protected]>
@KaWaite KaWaite closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants