From e9a191f16c75f00fa61269256d4162f31180bf08 Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Tue, 12 Sep 2023 21:36:08 -0400 Subject: [PATCH 1/4] Use default Node version in CI Deprecated Node versions are used in CI, potentially causing security and reliability issues. Instead, it's better to use GitHub's default Node version, which also doesn't require additional downloads or installations. --- .github/workflows/test.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c117407..802b197 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,7 +11,6 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: 16 cache: npm - name: Checkout code From 27c32ea00d556928781414ee0391b3494a88870e Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Tue, 12 Sep 2023 22:35:25 -0400 Subject: [PATCH 2/4] Fix action warnings --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 802b197..c6cb505 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,12 +9,12 @@ jobs: steps: - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: cache: npm - name: Checkout code - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Install dependencies run: npm ci From 5ad262a41953629b061b462e924381490a618e2b Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Tue, 12 Sep 2023 22:39:19 -0400 Subject: [PATCH 3/4] Fix order of actions (checkout then setup) --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c6cb505..d7f714c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,14 +8,14 @@ jobs: runs-on: ubuntu-latest steps: + - name: Checkout code + uses: actions/checkout@v3 + - name: Set up Node uses: actions/setup-node@v2 with: cache: npm - - name: Checkout code - uses: actions/checkout@v3 - - name: Install dependencies run: npm ci From a4e4f6b9d3980afbdf55c454111cb74d74be8b6d Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Tue, 12 Sep 2023 22:58:45 -0400 Subject: [PATCH 4/4] Update actions/setup-node --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d7f714c..ada5f04 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -12,7 +12,7 @@ jobs: uses: actions/checkout@v3 - name: Set up Node - uses: actions/setup-node@v2 + uses: actions/setup-node@v3 with: cache: npm