Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus and grafana port should not be accessible from any address, only myip #66

Open
hcoyote opened this issue Jun 2, 2023 · 1 comment · May be fixed by #67
Open

Prometheus and grafana port should not be accessible from any address, only myip #66

hcoyote opened this issue Jun 2, 2023 · 1 comment · May be fixed by #67

Comments

@hcoyote
Copy link
Contributor

hcoyote commented Jun 2, 2023

openmessaging-benchmark/driver-redpanda/deploy/provision-redpanda-aws.tf

Lines 176 to 188 in 8411e4a

#Prometheus/Dashboard access
ingress {
from_port = 9090
to_port = 9090
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
}
ingress {
from_port = 3000
to_port = 3000
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
}

This should probably be locked down to same address as used for general access to the security group from the tester's home node.

 cidr_blocks = ["${chomp(data.http.myip.body)}/32"]
@hcoyote
Copy link
Contributor Author

hcoyote commented Jun 2, 2023

#67 for pr.

@hcoyote hcoyote linked a pull request Jun 2, 2023 that will close this issue
Make default prom/grafana cidr rule be myip instead of 0.0.0.0/0 #67
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make default prom/grafana cidr rule be myip instead of 0.0.0.0/0 hcoyote/openmessaging-benchmark
1 participant
@hcoyote